Skip to main content

Please review the interactive test infrastructure for PBP environments

6 replies [Last post]
Anonymous

Hi Alexander,

Could you please review:

http://fisheye4.atlassian.com/changelog/cqme/?cs=1724&@csTD=false
http://fisheye4.atlassian.com/changelog/cqme/?cs=1725&@csTD=false
http://fisheye4.atlassian.com/changelog/cqme/?cs=1726&@csTD=false

This provides the interactive test functionality for CDC (well, PBP)
environment, along with the sample that demonstrates how to use it.

This is in line with our recent TCKs where similar approach has been
used. Also, this provides a possibility to create MDIP- and PBP-
targeted interactive tests at the same time, since the actual platform
is hidden via Helper class.

I tested the sample with AGUI RI, and it works fine.

Thanks,
--Vladimir

P.S. The actual package names are yet TBD, I could adjust them once the
good name/location is determined, don't pay attention to that. :)
[vladimir_sizikov.vcf]
---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Hi Alexander,

On 12/1/2009 12:37 PM, Alexander Alexeev wrote:
> Hi Vladimir,
>
> here my first comments...
>
> I propose to add "testclasspath" entry to the jtt file of the sample with
> something like that:
> $testSuiteRootDir$/classes$/preverified$:$testSuiteRootDir$/lib$/pbp_interactive.jar

Ah, I misread what you've written, and thought that you are talking
about "classpath" entry, but you were actually talking about
"testclasspath", which is exactly what is needed, and *does* work.

I'll update the sample to use this.

Any additional comments?

Thanks,
--Vladimir
[vladimir_sizikov.vcf]
---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Alexander Alexeev

Hi Vladimir,

I've finished review and got to run sample. My fault was to use main_agent.jar
instead Xlet.
Overall looks very nice :-). My only concerns about protected fields in the
InteractiveTest and DistribInteractiveServer. These classes are really public
API which will be used a lot. So protected fields are potential headache for the
code's support. Is it possible to make them private?

Thanks,
Alexander

Vladimir Sizikov wrote:
> Hi Alexander,
>
> On 12/1/2009 12:37 PM, Alexander Alexeev wrote:
>> Hi Vladimir,
>>
>> here my first comments...
>>
>> I propose to add "testclasspath" entry to the jtt file of the sample with
>> something like that:
>> $testSuiteRootDir$/classes$/preverified$:$testSuiteRootDir$/lib$/pbp_interactive.jar
>
>
> Ah, I misread what you've written, and thought that you are talking
> about "classpath" entry, but you were actually talking about
> "testclasspath", which is exactly what is needed, and *does* work.
>
> I'll update the sample to use this.
>
> Any additional comments?
>
> Thanks,
> --Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Hi Alexander,

On 12/1/2009 12:37 PM, Alexander Alexeev wrote:
> I propose to add "testclasspath" entry to the jtt file of the sample with
> something like that:
> $testSuiteRootDir$/classes$/preverified$:$testSuiteRootDir$/lib$/pbp_interactive.jar

I remembered why I didn't do that in the first place. Since it doesn't
work, the classpath for remote part is different from the classpath for
JTHarness itself.

But I agree that it would be good to have some simple way to adjust the
remote classpath without tweaking the interview. Will probably file a
bug for that.

For now, one have to use additional JAR files in the classpath on the
agent side.

> This entry used as classpath when agent is trying to load classes remotely.
> It eliminates requirement to add pbp_interactive.jar to the agent's startup
> classpath.

Simplifying that would be good, yeah. See above, I'll file the bug.

> I was unable to run the sample test suite. I used CDC Toolkit and got the
> following error while running test:
> "Unexpected exception during test run: java.lang.RuntimeException:
> Error: send
> called when no test is running"
>
> Do you have any ideas what may be wrong?

Yes, that means that something is very wrong on agent side, so that it
can't launch properly, and the other part (on JTharness side) gets
confused trying to send some messages while the test hasn't been started
due to problem on agent side. And sending the messages while the test
has not been started creates that problem.

At minimum, we should somehow provide better error messages, if
possible. I'll file a separate bug for that, and we could fix it later on.

But once the agent is started properly, everything should just work
fine. Please find attached a simple script to start an agent either in
Xlet mode or in standard mode. As we discussed some time ago, we should
add such scripts to the samples so that users won't have to struggle
with command line options, etc. This will be another issue filed in the
issue tracker. :)

Thanks,
--Vladimir

> Vladimir Sizikov wrote:
>> Hi Alexander,
>>
>> Could you please review:
>>
>> http://fisheye4.atlassian.com/changelog/cqme/?cs=1724&@csTD=false
>> http://fisheye4.atlassian.com/changelog/cqme/?cs=1725&@csTD=false
>> http://fisheye4.atlassian.com/changelog/cqme/?cs=1726&@csTD=false
>>
>> This provides the interactive test functionality for CDC (well, PBP)
>> environment, along with the sample that demonstrates how to use it.
>>
>> This is in line with our recent TCKs where similar approach has been
>> used. Also, this provides a possibility to create MDIP- and PBP-
>> targeted interactive tests at the same time, since the actual platform
>> is hidden via Helper class.
>>
>> I tested the sample with AGUI RI, and it works fine.
>>
>> Thanks,
>> --Vladimir
>>
>> P.S. The actual package names are yet TBD, I could adjust them once
>> the good name/location is determined, don't pay attention to that. :)
>
[744283968.txt]
[vladimir_sizikov.vcf]
---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Alexander Alexeev

Hi Vladimir,

here my first comments...

I propose to add "testclasspath" entry to the jtt file of the sample with
something like that:
$testSuiteRootDir$/classes$/preverified$:$testSuiteRootDir$/lib$/pbp_interactive.jar

This entry used as classpath when agent is trying to load classes remotely.
It eliminates requirement to add pbp_interactive.jar to the agent's startup
classpath.

I was unable to run the sample test suite. I used CDC Toolkit and got the
following error while running test:
"Unexpected exception during test run: java.lang.RuntimeException: Error: send
called when no test is running"

Do you have any ideas what may be wrong?

Thanks,
Alexander

Vladimir Sizikov wrote:
> Hi Alexander,
>
> Could you please review:
>
> http://fisheye4.atlassian.com/changelog/cqme/?cs=1724&@csTD=false
> http://fisheye4.atlassian.com/changelog/cqme/?cs=1725&@csTD=false
> http://fisheye4.atlassian.com/changelog/cqme/?cs=1726&@csTD=false
>
> This provides the interactive test functionality for CDC (well, PBP)
> environment, along with the sample that demonstrates how to use it.
>
> This is in line with our recent TCKs where similar approach has been
> used. Also, this provides a possibility to create MDIP- and PBP-
> targeted interactive tests at the same time, since the actual platform
> is hidden via Helper class.
>
> I tested the sample with AGUI RI, and it works fine.
>
> Thanks,
> --Vladimir
>
> P.S. The actual package names are yet TBD, I could adjust them once the
> good name/location is determined, don't pay attention to that. :)

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Hi Alexander,

On 12/1/2009 12:37 PM, Alexander Alexeev wrote:
> I propose to add "testclasspath" entry to the jtt file of the sample with
> something like that:
> $testSuiteRootDir$/classes$/preverified$:$testSuiteRootDir$/lib$/pbp_interactive.jar
>
> This entry used as classpath when agent is trying to load classes remotely.
> It eliminates requirement to add pbp_interactive.jar to the agent's startup
> classpath.

Yeah, great idea, will add.

> I was unable to run the sample test suite. I used CDC Toolkit and got the
> following error while running test:
> "Unexpected exception during test run: java.lang.RuntimeException:
> Error: send
> called when no test is running"
>
> Do you have any ideas what may be wrong?

Let me investigate. So, you're using just bare bones CDC Toolkit 1.0,
right? Let me try it too then.

Thanks,
--Vladimir
[vladimir_sizikov.vcf]
---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Alexander Alexeev

Vladimir,

> Let me investigate. So, you're using just bare bones CDC Toolkit 1.0,
> right? Let me try it too then.

Right!

Thanks,
Alexander

Vladimir Sizikov wrote:
> Hi Alexander,
>
> On 12/1/2009 12:37 PM, Alexander Alexeev wrote:
>> I propose to add "testclasspath" entry to the jtt file of the sample with
>> something like that:
>> $testSuiteRootDir$/classes$/preverified$:$testSuiteRootDir$/lib$/pbp_interactive.jar
>>
>> This entry used as classpath when agent is trying to load classes
>> remotely.
>> It eliminates requirement to add pbp_interactive.jar to the agent's
>> startup
>> classpath.
>
> Yeah, great idea, will add.
>
>> I was unable to run the sample test suite. I used CDC Toolkit and got the
>> following error while running test:
>> "Unexpected exception during test run: java.lang.RuntimeException:
>> Error: send
>> called when no test is running"
>>
>> Do you have any ideas what may be wrong?
>
> Let me investigate. So, you're using just bare bones CDC Toolkit 1.0,
> right? Let me try it too then.
>
> Thanks,
> --Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net