Skip to main content

Last Chance GFv3 Dev Guide & domain.xml Doc Reviews

12 replies [Last post]
Anonymous

GlassFish Engineers,

If you are listed in the Reviewers table for either of these manuals,
please make one last check of your sections and enter corrections in the
Comments table or email me. Those of you who are not in the Reviewers
table are welcome to comment as well. These books have been reviewed
previously, so they should be in good shape, but the more they're
reviewed, the better.

http://wiki.glassfish.java.net/Wiki.jsp?page=DeveloperSGuide

http://wiki.glassfish.java.net/Wiki.jsp?page=AdministrationReference

The official review period begins Monday, Nov. 23 and ends *Tuesday,
Dec. 1*. I'll be taking tomorrow and next week off, so I'm sending
these out today.

June
[att1.html]

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Shalini Muthukrishnan

Hi June,

June.Parks@Sun.COM wrote:
> Hi Shalini,
>
> Great review. I have a couple of questions, see below.
>
> On 11/27/09 03:02 AM, Shalini Muthukrishnan wrote:
>> - Page 240, Making JDBC Driver Jars available : Please add
>> glassfish_home/lib directory to the list.
> How would this differ from adding the driver JARs to
> /lib? Why would a user want to put them in
> /lib instead?
This is an other directory where user can put his jdbc driver to make it
available to the application server.
>> - Page 247, section Handling Invalid Connections : the examples for
>> asadmin set on the property should be changed to :
>> asadmin set
>> server.resources.jdbc-connection-pool.JCPool1.property.Prefer-Validate-Over-Recreate="true"
>>
> Jagadish says the property name is all caps,
> PREFER-VALIDATE-OVER-RECREATE. Please confirm the spelling.
It could also be set with init-caps like "Prefer-Validate-Over-Recreate".

Thanks,
Shalini.
> Unfortunately, because this is a property and not an attribute, I
> can't extract it from the configuration myself.
>
> June
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@glassfish.dev.java.net
> For additional commands, e-mail: dev-help@glassfish.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: users-help@glassfish.dev.java.net

June.Parks@Sun.COM

On 12/03/09 18:54, Shalini Muthukrishnan wrote:
> Hi June,
>
> June.Parks@Sun.COM wrote:
>> Hi Shalini,
>>
>> Great review. I have a couple of questions, see below.
>>
>> On 11/27/09 03:02 AM, Shalini Muthukrishnan wrote:
>>> - Page 240, Making JDBC Driver Jars available : Please add
>>> glassfish_home/lib directory to the list.
>> How would this differ from adding the driver JARs to
>> /lib? Why would a user want to put them in
>> /lib instead?
> This is an other directory where user can put his jdbc driver to make
> it available to the application server.
I figured that was the case, but you still haven't answered my
question. Why would a user want to put the driver JARs in
/lib instead of /lib? Would they be available
to multiple domains, if the user had them? Would they override JARs in
/lib? If there's no advantage to putting them in
/lib, why bother telling users they can do so?

June
>>> - Page 247, section Handling Invalid Connections : the examples for
>>> asadmin set on the property should be changed to :
>>> asadmin set
>>> server.resources.jdbc-connection-pool.JCPool1.property.Prefer-Validate-Over-Recreate="true"
>>>
>> Jagadish says the property name is all caps,
>> PREFER-VALIDATE-OVER-RECREATE. Please confirm the spelling.
> It could also be set with init-caps like "Prefer-Validate-Over-Recreate".
>
> Thanks,
> Shalini.
>> Unfortunately, because this is a property and not an attribute, I
>> can't extract it from the configuration myself.
>>
>> June
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@glassfish.dev.java.net
>> For additional commands, e-mail: dev-help@glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
> For additional commands, e-mail: users-help@glassfish.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: users-help@glassfish.dev.java.net

June.Parks@Sun.COM

On 11/27/09 03:36 AM, Shalini Muthukrishnan wrote:
> - Page 82, table 1-80, Please add *"Prefer-Validate-Over-Recreate"*
> property with a description.
I can't make up a description out of thin air. Please either provide a
description or refer me to a spec with a description. I also need the
default. Why is this a property and not an attribute? And why the
peculiar capitalization?

June

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: users-help@glassfish.dev.java.net

June.Parks@Sun.COM

On 12/ 2/09 03:21 PM, June.Parks@Sun.COM wrote:
> On 11/27/09 03:36 AM, Shalini Muthukrishnan wrote:
>> - Page 82, table 1-80, Please add *"Prefer-Validate-Over-Recreate"*
>> property with a description.
> I can't make up a description out of thin air. Please either provide
> a description or refer me to a spec with a description. I also need
> the default. Why is this a property and not an attribute? And why
> the peculiar capitalization?
>
> June
Never mind. I found a description elsewhere.

June

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: users-help@glassfish.dev.java.net

Jagadish Prasath Ramu

Hi June,

Please find the comments for the sections "Developing Connectors" and
"Built-in Factories for Custom Resources" in page 263
------------------------------------------------------------------------------------------------------------------------

1)
Page 221 : 3rd Paragraph

"developed in conformance with the Java EE Connector
Specification."
can be
"developed in conformance with the Java EE Connector Architecture
Specification."

2) Page 222 : Probably, we can add another standard context named
TransactionContext :
(same as already exisiting ExecutionContext, but conforms to
GenericContext
so that it can be submitted as a set of contexts)

[Taken from Java EE Tutorial by Chinmayee]
"Transaction Context :
The transaction context contract between the resource adapter and the
application server
leverages the Generic Work Context mechanism by describing a standard
WorkContext, the
TransactionContext. It represents the standard interface a resource
adapter can use to
propagate transaction context information from the EIS to the
application server."

3) Page 224 :
" In the Administration Console, open the Applications component and
select Connector
Modules. Deploy the module, or select the previously deployed module.
Specify the name of
the thread pool in the Thread Pool ID field. For details, click the
Help button in the
Administration Console.
"
can be re-phrased as :
" In the Administration Console, open the Applications component and
select Connector
Modules. Deploy the module and then goto resources >
resource-adapter-configs section and create a
resource-adapter configuration for the deployed connector. You can
select a thread-pool from
the list of available thread-pools.For details, click the Help button
in the
Administration Console.
"

4) Page 225 : Section : Overriding Configuration Properties :
You can also state that the same is possible via GUI
GUI > resources > resource-adapter-configs > create (new)

5) Page 226 : Section : Handling Invalid Connections :
property 'PreferValidateOverRecreate' is 'PREFER-VALIDATE-OVER-RECREATE'
5-a) applicable in the examples and the entire section.

6) Page 227 : We can add another section named "classloading-policy"
after the section "Setting the shutdown timeout"
You can use the same text as provided in "Administration reference
guide, element" including my comments on the same.

7) Page 228 : Remove section "Application scoped resources" as is not
available in v3

8) Probably, we can add the other new features of the connector 1.6
specification
a) Annotations
b) Bean validation.
[Even a reference to Java EE tutorial's connector section will be
helpful.
Annotations section is already available. AFAIK, chinmayee is working on
bean-validation section]

9) Page 263 : Section : Built-in Factories for Custom Resources :

We provide template resources xml files for these built-in factories.
They are available at
GF_INSTALL_DIR/lib/install/templates/resources/custom/
User can refer
GF_INSTALL_DIR/lib/install/templates/resources/custom/README and
appropriate template file for more details.

------------------------------------------------------------------------------------------------------------------------

Thanks,
-Jagadish

On Thu, 2009-11-19 at 10:59 -0800, June.Parks@Sun.COM wrote:
> GlassFish Engineers,
>
> If you are listed in the Reviewers table for either of these manuals,
> please make one last check of your sections and enter corrections in
> the Comments table or email me. Those of you who are not in the
> Reviewers table are welcome to comment as well. These books have been
> reviewed previously, so they should be in good shape, but the more
> they're reviewed, the better.
>
> http://wiki.glassfish.java.net/Wiki.jsp?page=DeveloperSGuide
>
> http://wiki.glassfish.java.net/Wiki.jsp?page=AdministrationReference
>
> The official review period begins Monday, Nov. 23 and ends Tuesday,
> Dec. 1. I'll be taking tomorrow and next week off, so I'm sending
> these out today.
>
> June

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: users-help@glassfish.dev.java.net

Shalini Muthukrishnan

Hi June,

Some comments on Administration Reference Guide :

- Page 79, validation-table-name : "This parameter is mandatory if and
only if *connection validation is enabled* and
connection-validation-method is set to table".

- Page 79, validation-classname : "This parameter is mandatory if
*connection validation is enabled* and connection-validation-method is
set to custom-validation".

- Page 79, init-sql : "Specifies an SQL string to be executed whenever a
*physical *connection *to the database *is created *from the pool *(not
*the connections that are *reused *from the pool*)."

- Page 81, wrap-jdbc-objects : Description wrongly states (in the last
line) that the default is false. This should be changed to "true".

- Page 82, table 1-80, Please add *"Prefer-Validate-Over-Recreate"*
property with a description.

Thanks,
Shalini.

June.Parks@Sun.COM wrote:
> GlassFish Engineers,
>
> If you are listed in the Reviewers table for either of these manuals,
> please make one last check of your sections and enter corrections in
> the Comments table or email me. Those of you who are not in the
> Reviewers table are welcome to comment as well. These books have been
> reviewed previously, so they should be in good shape, but the more
> they're reviewed, the better.
>
> http://wiki.glassfish.java.net/Wiki.jsp?page=DeveloperSGuide
>
> http://wiki.glassfish.java.net/Wiki.jsp?page=AdministrationReference
>
> The official review period begins Monday, Nov. 23 and ends *Tuesday,
> Dec. 1*. I'll be taking tomorrow and next week off, so I'm sending
> these out today.
>
> June

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: users-help@glassfish.dev.java.net

Jagadish Prasath Ramu

Hi June,
Please find attached the comments about "resources" and
"connector-service" sections for Administration reference guide (Domain
file format reference).

Thanks,
-Jagadish

On Fri, 2009-11-27 at 17:06 +0530, Shalini Muthukrishnan wrote:
> Hi June,
>
> Some comments on Administration Reference Guide :
>
> - Page 79, validation-table-name : "This parameter is mandatory if and
> only if *connection validation is enabled* and
> connection-validation-method is set to table".
>
> - Page 79, validation-classname : "This parameter is mandatory if
> *connection validation is enabled* and connection-validation-method is
> set to custom-validation".
>
> - Page 79, init-sql : "Specifies an SQL string to be executed whenever a
> *physical *connection *to the database *is created *from the pool *(not
> *the connections that are *reused *from the pool*)."
>
> - Page 81, wrap-jdbc-objects : Description wrongly states (in the last
> line) that the default is false. This should be changed to "true".
>
> - Page 82, table 1-80, Please add *"Prefer-Validate-Over-Recreate"*
> property with a description.
>
> Thanks,
> Shalini.
>
> June.Parks@Sun.COM wrote:
> > GlassFish Engineers,
> >
> > If you are listed in the Reviewers table for either of these manuals,
> > please make one last check of your sections and enter corrections in
> > the Comments table or email me. Those of you who are not in the
> > Reviewers table are welcome to comment as well. These books have been
> > reviewed previously, so they should be in good shape, but the more
> > they're reviewed, the better.
> >
> > http://wiki.glassfish.java.net/Wiki.jsp?page=DeveloperSGuide
> >
> > http://wiki.glassfish.java.net/Wiki.jsp?page=AdministrationReference
> >
> > The official review period begins Monday, Nov. 23 and ends *Tuesday,
> > Dec. 1*. I'll be taking tomorrow and next week off, so I'm sending
> > these out today.
> >
> > June
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@glassfish.dev.java.net
> For additional commands, e-mail: dev-help@glassfish.dev.java.net
>
[admin-reference-comments-for-resources-and-connectors.txt]
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: users-help@glassfish.dev.java.net

Shalini Muthukrishnan

Hi June,

Some comments from my side on Developers Guide Chapter 14.

- Page 240, Making JDBC Driver Jars available : Please add
glassfish_home/lib directory to the list.

- Page 240, Detecting Installed Drivers section needs a complete change.

The title could be "Automatic detection of Installed Drivers" with
description :

"The installed JDBC Drivers are detected automatically by the
Administration Console while creating a jdbc connection pool. Based on
the database vendor and resource type chosen on the Create JDBC
Connection Pool page, a list of datasource/driver implementation class
names are listed in the next page across "Datasource ClassName" or
"Driver ClassName". When a specific implementation classname is chosen,
the additional properties are introspected from the installed jdbc
driver and displayed in the Additional Properties section."

Please note that there is not button called Detect Installed Drivers.

- Page 241, in the section that explains the Ping attribute, a third
bullet could be added to mention "Ping can be set using asadmin set
domain.resources.jdbc-connection-pool.DerbyPool.ping=true"

- Page 242, Please note that Flush button is placed next to the Ping
button and not the top right corner of the page.

- Page 243, Using an initialization statement : Modify first line as
"You can specify a statement that executes every time a physical
connection to the database is created from the JDBC Connection pool (not
the connections that are reused from the pool)."

- Page 243, Using an initialization statement : Add an extra bullet
point to mention that init-sql can be set using asadmin set
domain.resources.jdbc-connection-pool.DerbyPool.init-sql=""

- Page 243, at the end of the page in statement caching, please add an
extra bullet point to mention that statement-cache-size can be set using
asadmin set
domain.resources.jdbc-connection-pool.DerbyPool.statement-cache-size=

- Page 244, Please remove the line : "You can set any value between 0
and 10" and add "You can set any positive non-zero value" in the first
paragraph.

- Page 244, in section Statement tracing : Please mention that
sql-trace-listeners can be set using asadmin set
domain.resources.jdbc-connection-pool.DerbyPool.sql-trace-listeners= separated list of listeners>

- Page 244 in section Statement tracing : Please modify the sentence as
"The module name under which the SQL operation is logged is
*javax.enterprise.resource.sqltrace.*"

- Page 244, in section Statement tracing , please mention that the
custom implementations of org.glassfish.api.jdbc.SQLTraceListener should
be made available to the application server (glassfish_home/lib).

- Page 244, in section Statement tracing , the sample SQL Trace record
can be changed to

[#|2009-11-27T15:46:52.202+0530|FINE|glassfishv3.0|javax.enterprise.resource.sqltrace.com.sun.gjc.util|_ThreadID=29;_ThreadName=Thread-1;ClassName=com.sun.gjc.util.SQLTraceLogger;MethodName=sqlTrace;|ThreadID=77
| ThreadName=p: thread-pool-1; w: 6 | TimeStamp=1259317012202 |
ClassName=com.sun.gjc.spi.jdbc40.PreparedStatementWrapper40 |
MethodName=executeUpdate | arg[0]=insert into table1(colName)
values(100) | arg[1]=columnNames | |#]

- Page 244, under section Connections : First item could have been :
"Disabling Pooling"

- Page 245, Disable Pooling should be the title for the description

- Page 245, please add a point to state that pooling can also be set
using asadmin set
domain.resources.jdbc-connection-pool.DerbyPool.pooling=false

- Page 245, in Disabling Pooling, please add the following : "The
existing system property
'*com.sun.enterprise.connectors.SwitchoffACCConnectionPooling*', that
turns off connection pooling in ACC and the new attribute *pooling* do
not affect each other.

Associate-with-thread functionality is invalid when pooling is disabled
and hence an exception will be thrown if it is set to true. An exception
will be thrown if Flush connection pool is done when pooling is disabled.

A warning will be logged when the following attributes are active as
they are useful in pooled environment only :

* connection-validation
* validate-atmost-once-period
* match-connections
* max-connection-usage
* idle-timeout "

- Page 245, section Associating connections with threads : add : asadmin
set
domain.resources.jdbc-connection-pool.DerbyPool.associate-with-thread=true

- Page 245, section Custom Connection Validation : At the end of the
page include this to the line : "..............if Connection Validation
Method is set to Custom Validation *and connection validation is turned
on*".

- Page 246, in the bullets mentioned for Custom Connection Validation,
please enter this as the first point : " Enable Connection Validation".
Maybe you could add how the attribute
domain.resources.jdbc-connection-pool.DerbyPool.is-connection-validation-required
is set to true before this step.

- Page 246, custom connection validation section, please mention the set
commands for all the attributes :

asadmin set
domain.resources.jdbc-connection-pool.DerbyPool.is-connection-validation-required=
true
asadmin set
domain.resources.jdbc-connection-pool.DerbyPool.connection-validation-method=custom-validation
asadmin set
domain.resources.jdbc-connection-pool.DerbyPool.validation-classname= implementation>

- Page 246, custom validation section, you could mention that the
administration console displays the validation classnames for the common
databases against the validation classname field.

- Page 247, section Handling Invalid Connections : the examples for
asadmin set on the property should be changed to :
asadmin set
server.resources.jdbc-connection-pool.JCPool1.property.Prefer-Validate-Over-Recreate="true"

- Page 248, wrapping connections section : second paragraph, last line
says that default is false which is wrong. Default is true.

- Page 249, please mention an asadmin set example for "Using
non-transactional-connections" as
domain.resources.jdbc-connection-pool.DerbyPool.non-transactional-connections=true

- Page 250, please add an asadmin set example for setting transaction
isolation level as "asadmin set
domain.resources.jdbc-connection-pool.DerbyPool.transaction-isolation-level="

- Page 250, table 14-1, i think the transaction isolation levels do not
have a "TRANSACTION_" appended to them. Please remove them.

- Page 251, allowing non-component-callers section, please add "asadmin
set
domain.resources.jdbc-connection-pool.DerbyPool.allow-non-component-callers=true"

Thanks,
Shalini.

June.Parks@Sun.COM wrote:
> GlassFish Engineers,
>
> If you are listed in the Reviewers table for either of these manuals,
> please make one last check of your sections and enter corrections in
> the Comments table or email me. Those of you who are not in the
> Reviewers table are welcome to comment as well. These books have been
> reviewed previously, so they should be in good shape, but the more
> they're reviewed, the better.
>
> http://wiki.glassfish.java.net/Wiki.jsp?page=DeveloperSGuide
>
> http://wiki.glassfish.java.net/Wiki.jsp?page=AdministrationReference
>
> The official review period begins Monday, Nov. 23 and ends *Tuesday,
> Dec. 1*. I'll be taking tomorrow and next week off, so I'm sending
> these out today.
>
> June

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: users-help@glassfish.dev.java.net

June.Parks@Sun.COM

Hi Shalini,

Great review. I have a couple of questions, see below.

On 11/27/09 03:02 AM, Shalini Muthukrishnan wrote:
> - Page 240, Making JDBC Driver Jars available : Please add
> glassfish_home/lib directory to the list.
How would this differ from adding the driver JARs to /lib?
Why would a user want to put them in /lib instead?
> - Page 247, section Handling Invalid Connections : the examples for
> asadmin set on the property should be changed to :
> asadmin set
> server.resources.jdbc-connection-pool.JCPool1.property.Prefer-Validate-Over-Recreate="true"
>
Jagadish says the property name is all caps,
PREFER-VALIDATE-OVER-RECREATE. Please confirm the spelling.
Unfortunately, because this is a property and not an attribute, I can't
extract it from the configuration myself.

June

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: users-help@glassfish.dev.java.net

Anissa Lam

June.Parks@Sun.COM wrote:
> Hi Shalini,
>
> Great review. I have a couple of questions, see below.
>
> On 11/27/09 03:02 AM, Shalini Muthukrishnan wrote:
>> - Page 240, Making JDBC Driver Jars available : Please add
>> glassfish_home/lib directory to the list.
> How would this differ from adding the driver JARs to
> /lib? Why would a user want to put them in
> /lib instead?
>> - Page 247, section Handling Invalid Connections : the examples for
>> asadmin set on the property should be changed to :
>> asadmin set
>> server.resources.jdbc-connection-pool.JCPool1.property.Prefer-Validate-Over-Recreate="true"
>>
> Jagadish says the property name is all caps,
> PREFER-VALIDATE-OVER-RECREATE. Please confirm the spelling.
> Unfortunately, because this is a property and not an attribute, I
> can't extract it from the configuration myself.
I just looked at the code. The pool property name is converted to all
upper case first before looking at. So, capitalization doesn't matter.

Anissa.
>
> June
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
> For additional commands, e-mail: users-help@glassfish.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: users-help@glassfish.dev.java.net

June.Parks@Sun.COM

Thanks, Anissa! In that case, I'll use all lower case, because it's
more consistent with other property names.

June

On 12/ 3/09 02:25 PM, Anissa Lam wrote:
>
>
> June.Parks@Sun.COM wrote:
>> Hi Shalini,
>>
>> Great review. I have a couple of questions, see below.
>>
>> On 11/27/09 03:02 AM, Shalini Muthukrishnan wrote:
>>> - Page 240, Making JDBC Driver Jars available : Please add
>>> glassfish_home/lib directory to the list.
>> How would this differ from adding the driver JARs to
>> /lib? Why would a user want to put them in
>> /lib instead?
>>> - Page 247, section Handling Invalid Connections : the examples for
>>> asadmin set on the property should be changed to :
>>> asadmin set
>>> server.resources.jdbc-connection-pool.JCPool1.property.Prefer-Validate-Over-Recreate="true"
>>>
>> Jagadish says the property name is all caps,
>> PREFER-VALIDATE-OVER-RECREATE. Please confirm the spelling.
>> Unfortunately, because this is a property and not an attribute, I
>> can't extract it from the configuration myself.
> I just looked at the code. The pool property name is converted to
> all upper case first before looking at. So, capitalization doesn't
> matter.
>
> Anissa.
>>
>> June
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
>> For additional commands, e-mail: users-help@glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
> For additional commands, e-mail: users-help@glassfish.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: users-help@glassfish.dev.java.net

Byron Nevins

[att1.html]