Skip to main content

Please review my fix for cr6464982

3 replies [Last post]
andreytitov
Offline
Joined: 2009-03-13
Points: 0

Synopsis:
Report Converter: highlight bad user input with a background color

I used default JT Preferences file to store colors data

https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1760

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Nice, looking good. At first glance, one thing that needs to be addressed is the implementation in UIF. The value needs to be cached - the current code is going to execute a lot of method calls each time it is called.

I think it's reasonable to store the value as a static variable - so it applies to all UIF objects in the system.

Future work - observer capability so that changes in this value can be propagated without restart, and the ability to set these colors in the Preference dialog.

andreytitov
Offline
Joined: 2009-03-13
Points: 0

I hope I didn't misunderstand you. Observer capability and a simple preference's Pane are also added and tested in FilesPane, so you can try it working. There are some undone things, e.g. inputs are always created white etc.

https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1766

https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1769

updated

Message was edited by: andreytitov

andreytitov
Offline
Joined: 2009-03-13
Points: 0

arhh, I have forgotten to comment code. I'll do it tomorrow.