Skip to main content

Please review doc changes.

4 replies [Last post]
bkurotsu
Offline
Joined: 2004-12-13

Please review this revision. All comments welcome.

The text that has not been reviewed is in popupmenu.html - review the whole seciton on Quick Pick Execution, especially step numbers 3-4.

https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1704

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
dlpharness
Offline
Joined: 2007-07-26

Bill and I reviewed popupmenu.html. My comments were integrated. Please review this portion of the Quick Pick Execution help, step 3.

3. Choose Execute these tests from the test tree pop-up menu.
* If the Test Manager contains a completed configuration, the harness displays a message to confirm the execute operation.
* If the Test Manager does not contain a completed configuration, the harness displays a message asking whether you want to complete the configuration or cancel the test run.

The current configuration, combined with the nodes selected in the tree, determine which tests will be executed. In the Test Manager Preferences, the option "Execution from tree popup includes configuration Tests to Run" determines how those selected nodes will affect the Tests to Run value in the configuration:
[b]
Box is unchecked (default)[/b]. The harness ignores the tests specified in the current configuration's Tests to Run question. It runs the tests selected in the test tree, subject to configuration Test Selection filters, such as keywords. This option is compatible with the behavior of test harnesses older than version 4.2.1.

[b]Box is checked[/b]. The harness compares the tests you selected in the test tree and the tests specified in the configuration's Tests to Run question to find a set of common tests. The harness then applies the configuration's Test Selection filters, such as keywords, to the common test set, producing the set of eligible tests.

bernhasc
Offline
Joined: 2008-11-11

Couple of comments

Item 3, bullet 2:
* ... a message asking (choose: "you" or "the user" (depending on who you (the JTH devs) intend to address by this statement: the reader or the user)) to complete the configuration or cancel the test run.
eg. ...a message asking you to complete ... or cancel.... (I'm telling you that it'll ask you to complete or cancel)
...a message asking the user to complete ... or cancel.... (I'm telling you that it'll ask the user to complete or cancel)

or: ... (you|the user) to either complete the config, or cancel the test run.
or (to make it like the 1st bullet): displays a message asking to complete ... or cancel ....

#2: The current configuration, combined with the nodes selected in the tree, determine

should be determines, not determine; however, I suspect the "combined w/ the nodes selected in the tree" is an integral part of what is to be executed. As it's written, the clause is optional, therefore the singular verb determines (The current config determines, not the current config determine). I propose something along the lines of:

Both the current config and the selected nodes ... determine ....
The current config (and | plus | along with) the selected nodes ... determine ....

Box is unchecked (default): .... It runs the selected tests in (from?) the test tree, ....

Edited by: bernhasc: added clarifications

Message was edited by: bernhasc

dlpharness
Offline
Joined: 2007-07-26

Thanks Bern,

I checked in the following changes to address your issues:

https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1709

I rewrote the note to avoid the clause. I looked at the prepositions in and from and I decided to stick with "in the test tree" (consistent with "click in the window") and "from the popup menu".

Thanks,

dawn

bkurotsu
Offline
Joined: 2004-12-13

Review completed and integrated in build 12.