Skip to main content

Please review fix for 6877042 - new TestResult API

5 replies [Last post]
bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
fda
Offline
Joined: 2005-05-27
Points: 0

New code is ok, but I think that observers should be notified of such changes, shouldn't they?
If extending observer interface is not applicable because of backward compatibility, updateOutput() can be used instead.

bkurotsu
Offline
Joined: 2004-12-13
Points: 0

I agree. Yes, new API was not added because it was an interface. I would like to defer the change until the next major release.

Do you think updatedOutput(startindex=0,endindex=0,text="")?

fda
Offline
Joined: 2005-05-27
Points: 0

I think updatedOutput(startindex=0,endindex=buffer.size(),text=""), endindex should point to the last available index of the section text, not the first.

bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Well, in this case, we just deleted all the buffer data, so the size() is zero by definition. We could code it the way you wrote though.

fda
Offline
Joined: 2005-05-27
Points: 0

please consider me fine with this change