Skip to main content

Please review my fix for cr6518341

7 replies [Last post]
andreytitov
Offline
Joined: 2009-03-13

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13

Oh, sorry for not responding, I approve too!

bkurotsu
Offline
Joined: 2004-12-13

Not sure I agree with the final behavior of the fix. The bug did not suggest a "correct" behavior.

I propose that it is not valid to have only one XML file and that checkInput() should fail if that is not true.

Further - the error message provided does not give the user guidance, like what OK means and consequences.

andreytitov
Offline
Joined: 2009-03-13

There is an error message "Input files are not defined" in checkInput() that occurs when no one XML file was provided. May be it should be expanded to check 2 files or it must be a separate check?

bkurotsu
Offline
Joined: 2004-12-13

Yes, let's do that - two files or more are required.

andreytitov
Offline
Joined: 2009-03-13
sergey_borodin
Offline
Joined: 2006-10-20

I verified the fix and agree with it.
Please, integrate.

Thanks,
Sergey Borodin

andreytitov
Offline
Joined: 2009-03-13

Thanks,
integrated as part of 1684