Skip to main content

Please review fix for cr6806408

1 reply [Last post]
andreytitov
Offline
Joined: 2009-03-13

Preferences object wasn't saved in case of no one ExecTool was opened while exiting JavaTest.

Preferences object was saved at preferences dialog closing and filters saving only. Filters are saved if there is at least one ExecTool.
Now Preferences is saved on: closing ExecTool (ExecTool.dispose()), saving Desktop (Desktop.save())

Also I've added up-to-date checking so Preferences will not rewrite file if no changes are applied
https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1590

updated:
May be it would be right to rewrite preferences file if it modified manually:
https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1591

btw, I noticed that currView in ConfigEditor is null when config editor dialog is created. Should I post new cr?

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
fda
Offline
Joined: 2005-05-27

Fix looks good to me.