Skip to main content

Please review my fix for CR 6605583

2 replies [Last post]
ersh
Offline
Joined: 2006-10-18
Points: 0

Here is the problem description:
------------------------
Javatest has a dialog that user can use to see contents of the Exclude List. It's accessible from View->Configuration->ShowExcludeList.

The caption of the dialog is changed according to the number of ExcludeList files, set in the Interview. For example:
- "No Exclude List Specified"
- "Exclude List: "
- "Exclude List: [N files]"

The problem is that Exclude List may be set without having any files set in the Interview. For example some test productes can override the com.sun.javatest.InterviewParamaters.getExcludeList() method in order to "hiddenly" specify exclude list.
As a result we have following user experience:
- no files are specified in Interview
- user opens View->Configuration->ShowExcludeList
- Dialog has caption "No Exclude List Specified"
- BUT it features some excluded tests.

Request: CAPTION of the ExcludedTests dialog should be user-friendly in such a way. I suggest to remove filenames at all. From this point of view it should only show the number of excluded tests. For example: "Excluded Tests: NN"
------------------------

So please review my fix
https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1552

Thank you,
Mike

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
fda
Offline
Joined: 2005-05-27
Points: 0

Looks good, pls, integrate.

ersh
Offline
Joined: 2006-10-18
Points: 0

Thanks, integreated