Skip to main content

Please review my fix for cr6505815

3 replies [Last post]
andreytitov
Offline
Joined: 2009-03-13
Points: 0

The quickstart dialog was opened several times in case of using several times File->Open Quick Start Dialog or Tools->Test Manager.

https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1530

Message was edited by: andreytitov

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13
Points: 0

New fix is much better, I approve of that version.

Side note, these "core" packages that have limited visibility of the others are:
- .util
- .tool
- .lib

Somewhat less established, but I think also adhering to this policy are:
- .interview
- .finder
- .cof
- .agent
These packages have no logical reason to depend on the other non-core packages (such as exec).

Additionally, these packages should be strictly non-GUI (no awt or swing dependencies - explicit or implicit. in effect, these packages should be able to run headless):
- .finder
- .lib
- .util
- .interview
- .batch
- .cof
- .junit
- .httpd
There may be slight exceptions - for example if there is one class in the package that is used to interface to the GUI - a ToolManager class.

fda
Offline
Joined: 2005-05-27
Points: 0

The fix works, but it makes the Desktop class dependent on the class from the different package: ExecTool. It's easy to avoid such kinda dependency defining isQuickStartWizardActive() right in the action class (ExecToolManager.java), not in Desktop.

In this case ExecTool.isQuickStartWizardShowing() can be kept package private.

andreytitov
Offline
Joined: 2009-03-13
Points: 0

Yeap, you are right

https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1542

Message was edited by: andreytitov