Skip to main content

Please review my fix for cr6624092

4 replies [Last post]
andreytitov
Offline
Joined: 2009-03-13

Report Converter tool data was dissapearing in case of any error occured in the second page of tool. Was desired the following behavior: "Wizard returns onto the 2nd page with all user input from the 1st page kept in action."

https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1492

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13

Integrated rev 1523 to trunk.

bkurotsu
Offline
Joined: 2004-12-13

And and just a reminder - please make code reviews a question, so we can more easily see what has been completed. Thanks!

bkurotsu
Offline
Joined: 2004-12-13

Well, the fix seems ok, but I want to ask about how that panel works (I know you didn't write it originally Andrey). I looked for a minute, but didn't figure it out.

The body is removed from the dialog if the options are accepted. Does this mean the GUI body is recreated when the dialog is displayed again? It is just a little suspect that the body is actually removed rather than just resetting the GUI and hiding the dialog.

Brian

andreytitov
Offline
Joined: 2009-03-13

> Does this mean the GUI body is recreated when the dialog is displayed again? It is just a little suspect that the body is actually removed rather than just resetting the GUI and hiding the dialog.

Yeap, it seems like it is recreated - initGUI method is called every time when the dialog is sucessfuly closed (except "Cancel" button)

btw "Cancel" button does not dissmiss any changes applyed to dialog contents