Skip to main content

Please review fix 6846853: "'" chars in i18n files should be escaped

2 replies [Last post]
fda
Offline
Joined: 2005-05-27

2 files updated:
javatest/i18n.properties
javatest/exec/i18n.properties

Indeed it's ok to use single ' in property values files unless parameters are present.
When parameters are used MessageFormat is used to substitute the parameter values.
The property value will be returned as is if it's expected to have no parameters.

I used the following script to identify suspicious strings:
grep "{" `find . -name i18n.properties` |sed -e "s/\'\'//g" |grep "'"

https://jtharness.dev.java.net/source/browse/jtharness?rev=1448&view=rev

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13

Three files updated, not two.

Changes look fine though, good work.

fda
Offline
Joined: 2005-05-27

Actually two :)
The third one was updated incorrectly and restored.
Integrated

Message was edited by: fda