Skip to main content

please review fix for 6484939: CustomTestResultViewer.setResult/onChangedSe

4 replies [Last post]
fda
Offline
Joined: 2005-05-27
Points: 0

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
fda
Offline
Joined: 2005-05-27
Points: 0

Please look as well at
https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1445

New updateCustomSubpanels() method is invoked after updatePanel() when test started/finished to
call setResult() for all custom viewer.

Note: updateCustomSubpanels() skips currentPanel because it will have been already updated by updatePanel() by that time.

bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Ok, looks fine. I think you meant rev 1452 though.

fda
Offline
Joined: 2005-05-27
Points: 0

integrated

fda
Offline
Joined: 2005-05-27
Points: 0

There is a spelling error in the onCangedTestResult() method, this method is intended to be overridden by JT users. Fix spelling will (might) cause the compilation problem, making it deprecated doesn't help as well.

I think we should either keep it as is or change the name and announce properly. Both variants are acceptable to me. I would opt for the first one, because I'm sure that is not only the one method spelled improperly.