Skip to main content

Please review fix for 6476766 - AgentClassLoader2 should define packages

7 replies [Last post]
fda
Offline
Joined: 2005-05-27
Points: 0

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Ah, something in the back of my mind which I didn't mention.

This class is designed to run and compile for old VMs, annotations are not allowed. I'll remove them for you - it was just overrides that you added.

fda
Offline
Joined: 2005-05-27
Points: 0

Thanks!

bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Ok, on topic for the class loader bug....

Seems fine, please integrate.

fda
Offline
Joined: 2005-05-27
Points: 0

integrated

bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Well, first comment, can we fix the spelling of that method? :(

I assume it was supposed to be onChangedTestResult(). For compatibility, could you please leave but deprecate the old method and just make it call the new method onChangedTestResult().

bkurotsu
Offline
Joined: 2004-12-13
Points: 0

On second thought, since that method is an observer method which we expect people to override...

Perhaps just deprecate? And call both when notifications are sent? What do you think?

fda
Offline
Joined: 2005-05-27
Points: 0

your comments are about the other bug: 6484939: CustomTestResultViewer, please see my thoughts there