Skip to main content

Please review fix for 6806506 - Create Report dialog sometimes malfunctions

5 replies [Last post]
fda
Offline
Joined: 2005-05-27
Points: 0

"HTML Option" checkboxes might have been enable, when "HTML Report" CB is off. Clicking "Configuration" CB might have caused disabling of the entire group of options, when checking/unchecking "HTML Report" CB had no effect.

Now:
- "HTML Option" checkboxes states are setting when the dialog appears
- changes state of "HTML Report" CB causes updateHtmlCheckboxStates() to be invoked.

minor change names:

method: updateCheckboxStates() --> updateHtmlCheckboxStates()
field: cbListener --> cbHtmlListener

https://jtharness.dev.java.net/source/browse/jtharness?rev=1418&view=rev

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Fix works great. Integrated to trunk.

Before closing this question though - I think we need to consider one improvement. If the report dir field is empty, the Create button is still enabled. True, it will put up a dialog if you press the Create button. But, perhaps this field should also have content before the button is enabled.

How about this:
- if report dir field is of length 0, Create button disabled
- if report dir field length > 0, Create button enabled

Any validation of the report dir field can be done AFTER the create button is pressed - so the error dialog which already exists does not need to be removed.

fda
Offline
Joined: 2005-05-27
Points: 0

I thought about disabling button util report dir is set, and I intentionally didn't that. To me, such behavior might confuse users (like me): it would be unclear what to do enable the button. Currently pressing the button will cause a directive to bring up.

bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Makes the dialog inconsistent though, since some entries are pre-validated (report types) and some are not (path).

fda
Offline
Joined: 2005-05-27
Points: 0

would you like me to fix this? I'm don't find the current behavior inconsistent, but I don't object to fix it as you suggest.

fda
Offline
Joined: 2005-05-27
Points: 0

submitter verified the fix, means that's ok.