Skip to main content

Please review fix for 6726833 - custom filter, summary and test list update

3 replies [Last post]
bkurotsu
Offline
Joined: 2004-12-13

Previous fix for NOT RUN tab (6702426) fixed some behavior, but the custom filter was still not always updating things.

https://jtharness.dev.java.net/source/browse/jtharness?rev=1410&view=rev

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13

Integrated review feedback in rev 1438. Closing this review.

https://jtharness.dev.java.net/source/browse/jtharness?rev=1438&view=rev

fda
Offline
Joined: 2005-05-27

Looks good to me. A couple minor comments:

1) new method [i]void update(InterviewParameters ip) [/i] introduced but not used.

2) new constants added for all, but 4
private static int KEY_FILTER = 0;
private static int URL_FILTER = 1;
private static int JTX_FILTER = 2;
private static int STATUS_FILTER = 3;

activeFilters[KEY_FILTER] = keyFilter;
activeFilters[URL_FILTER] = urlFilter;
activeFilters[JTX_FILTER] = jtxFilter;
activeFilters[STATUS_FILTER] = statusFilter;
activeFilters[4] = tsfFilter;

Would it make sense to define one more constant?

bkurotsu
Offline
Joined: 2004-12-13

Unmodified code integrated, rev 1420.

Yes Dima, I didn't do that cuz I think was thinking something else at the time, but now I agree. I'll make a followup change for that.