Skip to main content

Please review fix - 5072027: Some TestFilter subclasses are not hashtable-

6 replies [Last post]
fda
Offline
Joined: 2005-05-27

Filter Implementations are provided with hashCode() methods which are consistent with equals().

CompositeFilter.java
- hashCode added
ExcludeList.java
- equals/hashCode added
ExcludeListFilter.java
- hashCode added
Keywords.java
- minor refactoring + hashCode methods provided for each filter
StatusFilter.java
- hashCode added

Some minor refactoring was done for Keywords filters.

https://jtharness.dev.java.net/source/browse/jtharness?rev=1409&view=rev

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13

Integrated 1409 and 1425 to trunk rev 1432.

Thanks!

bkurotsu
Offline
Joined: 2004-12-13

Does not compile...

[javac] /Volumes/Big Case/work/java.net/foo/src/com/sun/javatest/Keywords.java:221: cannot find symbol
[javac] symbol : method isEmpty()
[javac] location: class java.lang.String
[javac] if (!allKwds.isEmpty()) {
[javac] ^

fda
Offline
Joined: 2005-05-27

JDK 6 method was called. Fixed. (Little did I know, that jdk1.5 must be used)

bkurotsu
Offline
Joined: 2004-12-13

Ok, looks fine then.

How extensively did you test the new equality and hash capabilities?

fda
Offline
Joined: 2005-05-27

I just checked that filters work. Not extensively.

bkurotsu
Offline
Joined: 2004-12-13

Almost done reviewing, just looking though Keywords changes...