Skip to main content

Please review fix - 6702426 BranchPanel NotRun tab not correctly enabled

3 replies [Last post]
bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Three files you don't really need to review. The fix simply changes the offset which is used to enable/disable tabs. It was acting on the wrong tab (-2 instead of -1). Not sure if calculating offsets will be the best thing to do in the long run, but it's how much of the code is written now - dynamic in a way, but also a hazard.

BranchPanel
- fix 6702426 BranchPanel NotRun tab not correctly enabled/disabled

BasicCustomTestFilter
- remove trailing spaces, retab code
- add some @override annotations
- no actual code change

TT_NodeCache
- remove trailing spaces, retab code
- no actual code change

BP_SummaryPanel
- remove trailing spaces, retab code
- no actual code change

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13
Points: 0
fda
Offline
Joined: 2005-05-27
Points: 0

reviewed. Looks like the offset change should help.

bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Integrated, rev 1420.