Skip to main content

Please review cr6445546 fix

3 replies [Last post]
andreytitov
Offline
Joined: 2009-03-13

Setting resolution for float constraints didn't affect on anything

Constraints are checked while updating value at properties table. Also added constraint checking before adding values into table model, so value can be automaticly changed according to constraints now.

https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1325

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
andreytitov
Offline
Joined: 2009-03-13
bkurotsu
Offline
Joined: 2004-12-13

Hi!

In PropertiesQuestion, right below the large block of new code, this remains:
if (!old.equals(val)) {

Should it not be:
if (!old.equals(strVal)) {

And could you describe how intensive your testing of the new code was?

Thanks!

andreytitov
Offline
Joined: 2009-03-13

Hi Brian,
thanks for reviewing!

About changing "!old.equals(val)" to "!old.equals(strVal)". I think, that it depends on what to define as configuration changing. "val" has modified value whenever "strVal" has, but not backward.

By the way... I have just looked in the code and found, that the line "interview.setEdited(true);" doesn't affect anything - it is possible to leave editor without saving if I change any value and then restore its value back.

I didn't test the code a lot, I have only make sure that constraint works. Also I changed testsuite a bit (it is _very_ buggy) to make sure that list will be blocked if float constraint fails on values like "1234.1a".