Skip to main content

[webtier] NPE-fix for configureValves in WebModule

2 replies [Last post]
Anonymous

I have attached the diff that fixes the NullPointerException, Sahoo detected. I will commit it as soon as it is reviewed.

Thanks,

--
Wolfram Rittmeyer

---------------------------------------------------------------------
To unsubscribe, e-mail: webtier-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: webtier-help@glassfish.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Wolfram Rittmeyer

Oh my, I forgot to attach the diff. So now as simple text:

Index: web-glue/src/main/java/com/sun/enterprise/web/WebModule.java
===================================================================
--- web-glue/src/main/java/com/sun/enterprise/web/WebModule.java
(revision 24958)
+++ web-glue/src/main/java/com/sun/enterprise/web/WebModule.java
(working copy)
@@ -869,7 +869,7 @@
* Configure the WebModule valves.
*/
protected void configureValves(){
- if (iasBean.getValve() != null && iasBean.sizeValve() > 0) {
+ if (iasBean != null && iasBean.getValve() != null &&
iasBean.sizeValve() > 0) {
com.sun.enterprise.deployment.runtime.web.Valve[] valves =
iasBean.getValve();
for (com.sun.enterprise.deployment.runtime.web.Valve
valve: valves) {
addValve(valve);

--
Wolfram

w.rittmeyer@jsptutorial.org wrote:
> I have attached the diff that fixes the NullPointerException, Sahoo detected. I will commit it as soon as it is reviewed.
>
> Thanks,
>
> --
> Wolfram Rittmeyer
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: webtier-unsubscribe@glassfish.dev.java.net
> For additional commands, e-mail: webtier-help@glassfish.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: webtier-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: webtier-help@glassfish.dev.java.net

Jan Luehe

Looks good, Wolfram!

Jan

On 02/25/09 07:08 AM, Wolfram Rittmeyer wrote:
> Oh my, I forgot to attach the diff. So now as simple text:
>
> Index: web-glue/src/main/java/com/sun/enterprise/web/WebModule.java
> ===================================================================
> --- web-glue/src/main/java/com/sun/enterprise/web/WebModule.java
> (revision 24958)
> +++ web-glue/src/main/java/com/sun/enterprise/web/WebModule.java
> (working copy)
> @@ -869,7 +869,7 @@
> * Configure the WebModule valves.
> */
> protected void configureValves(){
> - if (iasBean.getValve() != null && iasBean.sizeValve() > 0) {
> + if (iasBean != null && iasBean.getValve() != null &&
> iasBean.sizeValve() > 0) {
> com.sun.enterprise.deployment.runtime.web.Valve[] valves =
> iasBean.getValve();
> for (com.sun.enterprise.deployment.runtime.web.Valve
> valve: valves) {
> addValve(valve);
>
> --
> Wolfram
>
> w.rittmeyer@jsptutorial.org wrote:
>> I have attached the diff that fixes the NullPointerException, Sahoo
>> detected. I will commit it as soon as it is reviewed.
>>
>> Thanks,
>>
>> --
>> Wolfram Rittmeyer
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: webtier-unsubscribe@glassfish.dev.java.net
>> For additional commands, e-mail: webtier-help@glassfish.dev.java.net
>>
>>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: webtier-unsubscribe@glassfish.dev.java.net
> For additional commands, e-mail: webtier-help@glassfish.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: webtier-unsubscribe@glassfish.dev.java.net
For additional commands, e-mail: webtier-help@glassfish.dev.java.net