Skip to main content

Please review fix for cr_6750305

4 replies [Last post]
naryl
Offline
Joined: 2007-11-16

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
sergey_borodin
Offline
Joined: 2006-10-20

My comments:

https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1288

InterviewPropagator - please test propogation functionality before checkin

https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1307

TestSuite - harness object is not used. Remove. Need agreement with customers about gui output for NotificationLogger

ServiceManager - remove unused getHarness() method.

Please, fix noticed issues,
I'm agree with other changes.

Thanks,
Sergey

naryl
Offline
Joined: 2007-11-16

The user will be prompted for a new template if it is missing.

https://jtharness.dev.java.net/source/browse/jtharness?rev=1387&view=rev

sergey_borodin
Offline
Joined: 2006-10-20

Yes, this is desired behavoir. I'm agree.

--Sergey

bkurotsu
Offline
Joined: 2004-12-13

Was integrated, rev 1391 into trunk.