Skip to main content

Please review fix for bugs 6799142 and 6725861

5 replies [Last post]
sergey_borodin
Offline
Joined: 2006-10-20
Points: 0

Hi all,
Please review my fixes for CRs 6799142 and 6725861 - they describe the same problem - not all custom GUI control are loaded when we try to load test suite above empty exec tool.
It's safer just to close such tool and create new one, than try to update existing one. See ExecToolManager.showWorkDirectory() method, where the same logic is implemented.

Changeset is:
https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1295

Thanks,
Sergey

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
kromanovs
Offline
Joined: 2007-11-14
Points: 0

1. Does this change have any kind of side-effects, visible to users? I.e. user will see how ExecTool blinks (closes, then opens) in the main window at the startup time.

2. It also looks like you inject a testSuite object into execTool each time (when this situation happens).
t = new ExecTool(this, ts);
What would happen if Harness was started with -newDesktop option - so there's no testSuite available?

sergey_borodin
Offline
Joined: 2006-10-20
Points: 0

1.Empty exec tool closes fast - the process is showing as filling emty tool with test suite data.
2. You pointed to the code, which is executed most of time - when user tries to load test suite and there is no empty exec tool. Note, I just dropped one of two execution paths - those, where we tried to optimize our resources by reusing empty ExecTool object.
Didn't understood your last question - all changes I've done are in "Open->Test Suite ..." handler, how it depends on -newDesktop option? Could you please clarify?

Thanks,
Sergey

kromanovs
Offline
Joined: 2007-11-14
Points: 0

yes I misunderstood the code point. Change looks OK for me. Please test and commit.

sergey_borodin
Offline
Joined: 2006-10-20
Points: 0

Ok, tested and integrated.

Thanks,
Sergey

fyodr
Offline
Joined: 2007-12-27
Points: 0

if proposed solution works well then I okay with it