Skip to main content

Please review template fixes

1 reply [Last post]
sergey_borodin
Offline
Joined: 2006-10-20
Points: 0

Please review template fixes - these are CRs 6789398, 6789445, 6789389.

Changeset is:

https://jtharness.dev.java.net/source/browse/jtharness?view=rev&rev=1237

Comments for each file.

InterviewParameters
https://jtharness.dev.java.net/source/browse/jtharness/branches/users/sb...

The place where TEMPLATE_PATH was inserted inside template, instead of interview.
This is fix for 6789398.

ConfigEditor
https://jtharness.dev.java.net/source/browse/jtharness/branches/users/sb...

viewConfig should be cleared in any case, not only if isEdited() and equals() methods pass. It's more safe behavoir.

In case of templateMode we should remove template path from viewConfig.templateMode means, we're going to clear Config editor (actually, it's viewConfig, to have ability to roll back to mainConfig state by [X] button). That's why consistent viewConfig should be produced by clear(boolean) before invokation of setVisible(true). mainConfig will be synchronized with viewConfig later.

This is a fix for 6789389 and part of fix for 6789445.

ConfigHandler
https://jtharness.dev.java.net/source/browse/jtharness/branches/users/sb...

We shouldn't change the state of interviewParams directly, to prepare config editor. Instead, CE should adjust it's viewConfig before opening by himself, and have for mainConfig to save previous state.
Part of fix for 6789445.

Thanks,
Sergey Borodin

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Hard to see the scenarios for all of these, but at least some of the situations seem more logical than originally written.

Please integrate, and we'll test under real conditions.