Skip to main content

Please review mix for 6695334

6 replies [Last post]
naryl
Offline
Joined: 2007-11-16

Added a popup menu to copy filtered out tests' names to clipboard.

https://jtharness.dev.java.net/source/browse/jtharness?rev=1105&view=rev

btw, selection in these tables is not being copied to the Selection buffer on platforms which have it (X-server on any OS for example). Should it also be fixed?

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
naryl
Offline
Joined: 2007-11-16

> I don't think we need to handle the selection buffer situation

The problem is that user has no way to copy test names to an editor that doesn't know about Primary buffer. Text-mode vim for example.

bkurotsu
Offline
Joined: 2004-12-13

I don't think we need to handle the selection buffer situation - I used X11 a lot and never expected it to work in this case. Other opinions welcome.

Review of the fix:
You do this when entering actionPerformed():
final int[] rows = table.getSelectedRows();
I suggest delaying that call as long as possible and putting it inside the if statement. It wastes CPU to get this info if the event is going to be ignored.

Otherwise it looks ok. I actually can't figure out how to do right click on the table using the Mac with only one button. So couldn't test it...

Please integrate to trunk and tree-int and update the bug, thanks!

bernhasc
Offline
Joined: 2008-11-11

I think it's something like openapple - Shift - click; I'll check when I get back in the office tomorrow AM.

Edit (bernhasc) - Hmmm. that might be middle-click instead.

bernhasc
Offline
Joined: 2008-11-11

I was close...
Option - Click is Middle-Click.
OpenApple - Click is Right-Click.
Control-Option-Click is Control-Middle-Click.
Control-OpenApple-Click is Control-Right-Click.

bkurotsu
Offline
Joined: 2004-12-13

Thanks, that's what I thought.

Doesn't work for this panel though. Command (open apple)-click deselects an item from the list, because it is a multiple selection list.

Alexander - it works, but not on the Mac. Which seems to be how it is on the other tabs as well.

I approve the integration, please put it into tree-int and trunk. Then, please file an issue tracker bug saying that right click doesn't work on Mac OS in these test lists.

Thanks!

naryl
Offline
Joined: 2007-11-16

Done.