Skip to main content

Please review my fix for 6390687

5 replies [Last post]
naryl
Offline
Joined: 2007-11-16

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
ersh
Offline
Joined: 2006-10-18

It looks like the suggested fix rises the exception if the input string starts with "#" character, right? Also please take into account Brian's concern about backward behavior compatibility.

bkurotsu
Offline
Joined: 2004-12-13

I think we should make a little allowance for legacy files - where the user edited each line manually and might have included comments.

Could you make a static setting in the class. Following the same pattern suggested to Sergey in the QSW thread here in the forum.

static boolean allowInlineEnvComments = Boolean.parseBoolean(
System.getProperty("com.sun.javatest.InlineEnvComments", "false");

Follow the pattern Sergey used though, com.sun.javatest.InlineEnvComments is a constant in the class, etc...

So, retain your fix, but based on this new setting, apply the old behavior if inline comments are enabled (which is not the default value though).

Make sense?

thanks,
Brian

naryl
Offline
Joined: 2007-11-16

Done. Did I understand correctly that the fix should be disabled by default?

https://jtharness.dev.java.net/source/browse/jtharness/branches/users/na...

bkurotsu
Offline
Joined: 2004-12-13

Looks correct, thanks!

bkurotsu
Offline
Joined: 2004-12-13

Integrated into trunk and tree-int branch.