Made '#' only valid in the beginning of a word
It looks like the suggested fix rises the exception if the input string starts with "#" character, right? Also please take into account Brian's concern about backward behavior compatibility.
I think we should make a little allowance for legacy files - where the user edited each line manually and might have included comments.
Could you make a static setting in the class. Following the same pattern suggested to Sergey in the QSW thread here in the forum.
static boolean allowInlineEnvComments = Boolean.parseBoolean(
Follow the pattern Sergey used though, com.sun.javatest.InlineEnvComments is a constant in the class, etc...
So, retain your fix, but based on this new setting, apply the old behavior if inline comments are enabled (which is not the default value though).
Done. Did I understand correctly that the fix should be disabled by default?
Looks correct, thanks!
Integrated into trunk and tree-int branch.
Your use of this web site or any of its content or software indicates your agreement to be bound by these Terms of Participation.
Copyright © 2014, Oracle and/or its affiliates. All rights reserved. Oracle and Java are registered trademarks of Oracle and/or its affiliates. Other names may be trademarks of their respective owners.