Skip to main content

proposed fix for issue 51

2 replies [Last post]
jonathan_gibbons
Offline
Joined: 2005-07-06
Points: 0

Issue 51 describes a bug in JT Harness 4.1.3 whereby JT Harness ignores tests in the test suite root directory. Per Brian K's request, I am posting a proposed patch here. Could someone review the patch and apply it to branch 413a, please. (I just have an Observer role, so do not have permissions to apply the patch myself.)

Thanks,
-- Jon

Here are the diffs (they are also in Issue 51.)

jjg@gzillapc:/w/jjg/work/os-jtreg$ svn diff
jtharness-4_1_3-MR1-Rel-b08/code/src/com/sun/javatest/TRT_TreeNode.java
Index: jtharness-4_1_3-MR1-Rel-b08/code/src/com/sun/javatest/TRT_TreeNode.java
===================================================================
--- jtharness-4_1_3-MR1-Rel-b08/code/src/com/sun/javatest/TRT_TreeNode.java
(revision 913)
+++ jtharness-4_1_3-MR1-Rel-b08/code/src/com/sun/javatest/TRT_TreeNode.java
(working copy)
@@ -616,6 +616,10 @@

// to prevent infinite recursion
if (filesToScan == null) filesToScan = new String[0];
+
+ for (int i = 0; i < filesToScan.length; i++) {
+ processFile(new File(filesToScan[i]));
+ }
}

File thisDir = new File(TestResultTable.getRootRelativePath(this));

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Fix is now in the 4.1.3a branch. Will be integrating into the 4.1.4 branch and trunk.

bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Looks logical. Integrated.