Skip to main content

Please review my fix for CR 6670451

4 replies [Last post]
sergey_borodin
Offline
Joined: 2006-10-20

Please review my fix for this CR.

diff is:
https://jtharness.dev.java.net/source/browse/jtharness?rev=876&view=rev

The main idea of static getInterview(WorkDirectory) method inside ExecTool is that it istantiates object of InterviewParameters subclass, and, if work dir contains history of used .jti files, loads last one.
But if there was no on .jti record inside history, but work dir is using some template, this template should be loaded inside InterviewParameters object for this object to be consistent.

Thanks,
Sergey

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
fyodr
Offline
Joined: 2007-12-27

suggested fix looks reasonable
and it works
commit and ask for a b04 snapshot

sergey_borodin
Offline
Joined: 2006-10-20

Integrated.

--sergey

sergey_borodin
Offline
Joined: 2006-10-20

There was additional problem found - when we open work directory using "Recent Work Directory" menu, not Open->Work Directory.

The problem is that execution path changes and goes through src, equal to ExecTool.getInterview(), but not updated by my fix.
This code duplication removed.

diff is:
https://jtharness.dev.java.net/source/browse/jtharness?rev=906&view=rev

Integrated into trunk.

Thanks,
Sergey

sergey_borodin
Offline
Joined: 2006-10-20

During refactoring 2 catch statements of ExecToolManager's duplicate were lost.

Inserted them inside getInterview() method.

diffs are:
https://jtharness.dev.java.net/source/browse/jtharness?rev=910&view=rev

Integrated into trunk.

--Sergey