Skip to main content

Please review fix for CR 6675527

2 replies [Last post]
sergey_borodin
Offline
Joined: 2006-10-20

Please review fix for CR 6675527.

diff is:
https://jtharness.dev.java.net/source/browse/jtharness?rev=864&view=rev

Small clarification - there is a chain of components, which propagate custom renderers map from general container(ConfigEditor) to one particular component (QuestionPanel). Chain was becoming broken on path ConfigEditor - CE_FullView, because propagation occured in show() method, which is used not always. Now we try to pass map for next chain's element as soon as possible.

Was tested - no problems found.

Thanks,
Sergey Borodin

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13

I approve as long as you tested it with a test suite which uses custom renderers (which I hope is what you meant by the testing you already did).

sergey_borodin
Offline
Joined: 2006-10-20

OK,
Integrated