Skip to main content

Please review my fix for CR 6562026

3 replies [Last post]
sergey_borodin
Offline
Joined: 2006-10-20
Points: 0

The problem was in that UIFactory object passed in constructor was from com.sun.javatest.exec package, while usually in was related with com.sun.javatest.tools resource bundle.

Decided SelectedWorkDirApprover doesn't need external UIFactory at all, as all resources hardcoded and situated in the same package.

diffs are:
https://jtharness.dev.java.net/source/browse/jtharness?rev=830&view=rev
https://jtharness.dev.java.net/source/browse/jtharness?rev=831&view=rev

Thanks,
Sergey Borodin

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13
Points: 0

I seem to agree with the fix. I am surprised though - do you know why we originally passed uif as a parameter to the constructor?

Brian

sergey_borodin
Offline
Joined: 2006-10-20
Points: 0

I don't know, why.

But I can suppose that it was first designed to be used in one particular place - com.sun.javatest.tool.WorkDirChooser. And this object alreday has it's own instance of UIFactory, and it was convenient to reuse it.

Thanks,
Sergey

sergey_borodin
Offline
Joined: 2006-10-20
Points: 0

Integrated.

Sergey