Skip to main content

Please review fix for issue 209

1 reply [Last post]
Anonymous

Hi Vladimir,

please review fix for [ISSUE #209]: Serial: tests may have status error with low
buad rate.
The main reason cause failure was blocking registrator's thread for the long
time in waiting for the object's monitor. Now I'm thinking about turning
timeouts in registration/checking registration services.

http://fisheye4.cenqua.com/changelog/cqme/?cs=1539

Thanks,
Alexander

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Hi Alexander,

The fix looks good, but it makes me a bit uneasy, since it affects the
main execution infrastructure and these threading issues are always tricky.

Could you please put a big note in the issue tracker about extensive QA
checks to verify this bug. I think that not only slow serial connection
should be tested, but also UDP "connection" with very small UDP packet size.

Please commit.

Thanks,
--Vladimir

On 3/18/2008 4:50 PM, Alexander Alexeev wrote:
> Hi Vladimir,
>
> please review fix for [ISSUE #209]: Serial: tests may have status error
> with low
> buad rate.
> The main reason cause failure was blocking registrator's thread for the
> long
> time in waiting for the object's monitor. Now I'm thinking about turning
> timeouts in registration/checking registration services.
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=1539
>
> Thanks,
> Alexander
[vladimir_sizikov.vcf]
---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net