Skip to main content

Please review fix for issue 280

2 replies [Last post]
Anonymous

Hi Vladimir,

please review fix for [ISSUE #280]: CDCAgent always needs permission
createClassLoader

http://fisheye4.cenqua.com/changelog/cqme/?cs=1530

Accidentally I've committed changes to trunk. Hope it's not a big issue ;-)

Please also view my comments on 282 issue:
https://cqme.dev.java.net/issues/show_bug.cgi?id=282

Thanks,
Alexander

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Hi Alexander,

I'm OK with this fix, since it unblocks those who wait on this
to be fixed.

One more thought though: Maybe we should have a command line switch to
explicitly enable/disable local/remote loading?

In such case, if user explicitly stated that local class loading is
required, then there will be no need to print even a warning about
inability to obtain the classloader, there will be no need to create
that loader at all. And if user explicitly states that remote class
loading required (this should probably be default behavior), then we
could print error in case if class loader cannot be created. And this
time, we actually can print the full stack trace, and exit.

What do you think?

Thanks,
--Vladimir

On 3/4/2008 2:33 PM, Alexander Alexeev wrote:
> Hi Vladimir,
>
> please review fix for [ISSUE #280]: CDCAgent always needs permission
> createClassLoader
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=1530
>
> Accidentally I've committed changes to trunk. Hope it's not a big issue
> ;-)
>
> Please also view my comments on 282 issue:
> https://cqme.dev.java.net/issues/show_bug.cgi?id=282
>
> Thanks,
> Alexander
[vladimir_sizikov.vcf]
---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Alexander Alexeev

Hi Vladimir,

I was thinking about it also. But the situation is more complex. We already have
option for local class loading - "-classpath" argument. The separate local
classpath is needed to create separate class loader for each test and so prevent
accumulation of classes in memory. In case of impossibility to create class
loader this option is useless - all classes will be loaded by bootstrap class
loader and will be in memory until tests' run finish or until OutOfMemory error
;-). So we need to introduce similar option for this case and nothing is better
than "-preventRemoteLoading" don't came into my mind.

Thanks,
Alexander

Vladimir Sizikov wrote:
> Hi Alexander,
>
> I'm OK with this fix, since it unblocks those who wait on this
> to be fixed.
>
> One more thought though: Maybe we should have a command line switch to
> explicitly enable/disable local/remote loading?
>
> In such case, if user explicitly stated that local class loading is
> required, then there will be no need to print even a warning about
> inability to obtain the classloader, there will be no need to create
> that loader at all. And if user explicitly states that remote class
> loading required (this should probably be default behavior), then we
> could print error in case if class loader cannot be created. And this
> time, we actually can print the full stack trace, and exit.
>
> What do you think?
>
> Thanks,
> --Vladimir
>
> On 3/4/2008 2:33 PM, Alexander Alexeev wrote:
>> Hi Vladimir,
>>
>> please review fix for [ISSUE #280]: CDCAgent always needs permission
>> createClassLoader
>>
>> http://fisheye4.cenqua.com/changelog/cqme/?cs=1530
>>
>> Accidentally I've committed changes to trunk. Hope it's not a big
>> issue ;-)
>>
>> Please also view my comments on 282 issue:
>> https://cqme.dev.java.net/issues/show_bug.cgi?id=282
>>
>> Thanks,
>> Alexander

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net