Skip to main content

Please review fix for #271 and #272 issues

2 replies [Last post]
Anonymous

Hi Vladimir,

please review fix for [ISSUE #271]: "Incorrect behavior in case no agents were
connected" and [ISSUE #272]: "Agent waiting timeout works only for first run of
tests". I have to forward mail with commit since the FishEye haven't been
updated.

The main reason for incorrect behavior was wrong synchronization of
NotifiedTestInfo - waitUntilDone() may hangs up forever in wait() method.

The one open question remains - do we need to setup initial timeout through
interview? For more information see evaluation for [ISSUE #271]:
https://cqme.dev.java.net/issues/show_bug.cgi?id=271

Thanks,
Alexander
[email.eml]
---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Hi Alexander,

Most changes are good, but I have one question for you here.

One of the change was to remove internal monitor and use this
to synchronize on. Usually, such things are discouraged, since
we kind of expose internal synchronization to external world.

Was there a particular need for such change?

As for timeout in the interview, I think we should check with our
QA folks, since they have the most experience of running test suites
in various environments (including automation, etc). Personally,
I'd prefer not to add more stuff to the interview, since it would
take effort to maintain, document, test more complex interviews,
and it would also require some additional actions on user side,
in order to read question, understand it, etc. The simpler the better!

Thanks,
--Vladimir

On 2/20/2008 9:24 AM, Alexander Alexeev wrote:
> Hi Vladimir,
>
> please review fix for [ISSUE #271]: "Incorrect behavior in case no
> agents were
> connected" and [ISSUE #272]: "Agent waiting timeout works only for first
> run of
> tests". I have to forward mail with commit since the FishEye haven't been
> updated.
>
> The main reason for incorrect behavior was wrong synchronization of
> NotifiedTestInfo - waitUntilDone() may hangs up forever in wait() method.
>
> The one open question remains - do we need to setup initial timeout through
> interview? For more information see evaluation for [ISSUE #271]:
> https://cqme.dev.java.net/issues/show_bug.cgi?id=271
[vladimir_sizikov.vcf]
---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Alexander Alexeev

Hi Vladimir,

you are right, more safely to use monitor object. I fixed this and
committed changes.

Thanks,
Alexander

Vladimir Sizikov wrote:
> Hi Alexander,
>
> Most changes are good, but I have one question for you here.
>
> One of the change was to remove internal monitor and use this
> to synchronize on. Usually, such things are discouraged, since
> we kind of expose internal synchronization to external world.
>
> Was there a particular need for such change?
>
> As for timeout in the interview, I think we should check with our
> QA folks, since they have the most experience of running test suites
> in various environments (including automation, etc). Personally,
> I'd prefer not to add more stuff to the interview, since it would
> take effort to maintain, document, test more complex interviews,
> and it would also require some additional actions on user side,
> in order to read question, understand it, etc. The simpler the better!
>
> Thanks,
> --Vladimir
>
>
> On 2/20/2008 9:24 AM, Alexander Alexeev wrote:
>> Hi Vladimir,
>>
>> please review fix for [ISSUE #271]: "Incorrect behavior in case no
>> agents were
>> connected" and [ISSUE #272]: "Agent waiting timeout works only for
>> first run of
>> tests". I have to forward mail with commit since the FishEye haven't been
>> updated.
>>
>> The main reason for incorrect behavior was wrong synchronization of
>> NotifiedTestInfo - waitUntilDone() may hangs up forever in wait() method.
>>
>> The one open question remains - do we need to setup initial timeout
>> through
>> interview? For more information see evaluation for [ISSUE #271]:
>> https://cqme.dev.java.net/issues/show_bug.cgi?id=271

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net