Skip to main content

JUnit library review...

4 replies [Last post]
bkurotsu
Offline
Joined: 2004-12-13

Please review the latest code in my branch which adds JUnit support.
https://jtharness.dev.java.net/svn/jtharness/branches/users/bkurotsu/jth...

The new files are in code/src/com/sun/javatest/junit/. Also changed were code/build/build.properties classpath and local.properties.

----

One disadvantage here is that it now requires junit.jar and ASM to build. Please comment about whether you think this is too annoying. We could split the code into an optional jar that users are not required to build.

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13

Relevant jars required can be found at:

ASM library:
http://asm.objectweb.org/

JUnit:
http://junit.sourceforge.net/

Adjust local.properties as needed. I'm adjusting the build now so that junit is not built for the "build" target. It will be required for the "dist" target. You can invoke the "jar.junit" target to manually force it to build jt-unit.jar.

ersh
Offline
Joined: 2006-10-18

> One disadvantage here is that it now requires
> junit.jar and ASM to build. Please comment about
> whether you think this is too annoying. We could
> split the code into an optional jar that users are
> not required to build.

I would like to have possibility to build JT with no extra libs. I see two ways - to build optional jar or ignore some particular functionality (don't build it but print proper warnings) if the necessary extra libs were not specified.

Mike Ershov

bkurotsu
Offline
Joined: 2004-12-13

I don't disagree. Build has been reworked to produce jt-junit.jar instead. Invoke jar.junit target to build junit libs.

Also refactored MultiTest classes - should have no functional difference.

Merge with trunk to update branch:
https://jtharness.dev.java.net/source/browse/jtharness?rev=740&view=rev

Update build:
https://jtharness.dev.java.net/source/browse/jtharness?rev=742&view=rev

Update build and refactor classes:
https://jtharness.dev.java.net/source/browse/jtharness?rev=743&view=rev

ersh
Offline
Joined: 2006-10-18

The build looks good and workable. But the code on your branch is not compilable. I merged trunk with your branch and after that replaced javatest.junit java files by files you sent. In this case everything is good.