Skip to main content

Re: Code review: PP/PBP code diffs for CDC WinCE build

2 replies [Last post]
Anonymous

Hi Davy,

I have a question from Darryl. In the following file for your code
submission:

build/share/defs_personal_pocketpc.mk:

There is the addition to:

CLASSLIB_CLASSES

of the following:

sun.awt.pocketpc.PPCKeyboardFocusManager

I'm thinking that might just be something that was copied from the Qt
port and you don't need that for the Pocket PC port since that class is
not in src/share/personal/classes/awt/peer_based/sun/awt/pocketpc/.

Is that correct?

Thanks,

Hinkmond

---------------------------------------------------------------------
To unsubscribe, e-mail: advanced-unsubscribe@phoneme.dev.java.net
For additional commands, e-mail: advanced-help@phoneme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
davyp
Offline
Joined: 2007-01-03

Hi Hinkmond,

Could you tell me to which tree you are referring?

I had a look at my patches but could not find 'sun.awt.pocketpc.PPCKeyboardFocusManager'
anywhere. A grep on the code-subm-pp-winmobile branch did not find anything either. I also
looked at https://j2me-cdc.dev.java.net/code-reviews/phoneME/davyp-pp-winmobile-20...
but again I do not see the change to 'build/share/defs_personal_pocketpc.mk' you mentioned.

What I did add was the PPCKeyboardFocusManager.o line. That one provides the JNI bindings
for src/share/personal/classes/common/java/awt/KeyboardFocusManager.java.

Regards,
Davy

Hinkmond Wong

phonemeadvanced@mobileandembedded.org wrote:
> Hi Hinkmond,
>
> Could you tell me to which tree you are referring?
>
> I had a look at my patches but could not find 'sun.awt.pocketpc.PPCKeyboardFocusManager'
> anywhere. A grep on the code-subm-pp-winmobile branch did not find anything either. I also
> looked at https://j2me-cdc.dev.java.net/code-reviews/phoneME/davyp-pp-winmobile-20...
> but again I do not see the change to 'build/share/defs_personal_pocketpc.mk' you mentioned.
>
> What I did add was the PPCKeyboardFocusManager.o line. That one provides the JNI bindings
> for src/share/personal/classes/common/java/awt/KeyboardFocusManager.java.

Sorry, Davy. You are correct. I misread the initial question from
Darryl. The addition of the PPCKeyboardFocusManager.o line in
build/share/defs_personal_pocketpc.mk is there correctly.

The rest of the changes look OK to me. For everyone else, this is the
last call for final comments before I merge Davy's changes back to the
trunk.

https://j2me-cdc.dev.java.net/code-reviews/phoneME/davyp-pp-winmobile-20...

Thanks!

Hinkmond

---------------------------------------------------------------------
To unsubscribe, e-mail: advanced-unsubscribe@phoneme.dev.java.net
For additional commands, e-mail: advanced-help@phoneme.dev.java.net