Skip to main content

Please review #261: Redundant properties in jti file

3 replies [Last post]
Anonymous

Hi Alexander, folks,

Could you please review the fix for:
ISSUE #261: Redundant properties in jti file.

http://fisheye4.cenqua.com/changelog/cqme/?cs=1487

The fix overrides Interview.save(), in order not to save
unrelated question values.

I tested with simple CDC stack test suite, and CLDC values are no more
in the jti file.

Thanks,
--Vladimir
[vladimir_sizikov.vcf]
---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Alexander Alexeev

Hi Vladimir,

smart solution! Just seems diff in BasicTckInterview is not related to the fix.
Is it intentional?

Thanks,
Alexander

Vladimir Sizikov wrote:
> Hi Alexander, folks,
>
> Could you please review the fix for:
> ISSUE #261: Redundant properties in jti file.
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=1487
>
> The fix overrides Interview.save(), in order not to save
> unrelated question values.
>
> I tested with simple CDC stack test suite, and CLDC values are no more
> in the jti file.
>
> Thanks,
> --Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Hi Alexander,

On 1/22/2008 3:34 PM, Alexander Alexeev wrote:
> smart solution!

:)

> Just seems diff in BasicTckInterview is not related to
> the fix. Is it intentional?

Yeah, and it took me few hours to figure out this change.
You see, the Builder of the BasicTckInterview was originally
calling to the chain-constructor, and then the called constructor was
creating a non-customized VmInterview instance. After that the Builder
was creating the customized VmInterview which was actually
used, and until now everything was more or less fine.

Except for one thing: both VmInterview instances were still in
the list of children of the main Interview.

And Interview.save() is implemetned in such a way that it
invokes all children's save() methods. So, that
non-customized, non-used, but still existing VmInterview
instance was writing the CLDC-specific entries into
the jti file, even though the correct one wasn't.

The change was not to invoke the chain-constructor, but invoke super(),
thus avoiding creation of duplicated VmInterview.

Thanks,
--Vladimir

[vladimir_sizikov.vcf]
---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Alexander Alexeev

Vladimir,

Oh, I see. Please commit.

Thanks,
Alexander

Vladimir Sizikov wrote:
> Hi Alexander,
>
> On 1/22/2008 3:34 PM, Alexander Alexeev wrote:
>> smart solution!
>
> :)
>
>> Just seems diff in BasicTckInterview is not related to the fix. Is it
>> intentional?
>
> Yeah, and it took me few hours to figure out this change.
> You see, the Builder of the BasicTckInterview was originally
> calling to the chain-constructor, and then the called constructor was
> creating a non-customized VmInterview instance. After that the Builder
> was creating the customized VmInterview which was actually
> used, and until now everything was more or less fine.
>
> Except for one thing: both VmInterview instances were still in
> the list of children of the main Interview.
>
> And Interview.save() is implemetned in such a way that it
> invokes all children's save() methods. So, that
> non-customized, non-used, but still existing VmInterview
> instance was writing the CLDC-specific entries into
> the jti file, even though the correct one wasn't.
>
> The change was not to invoke the chain-constructor, but invoke super(),
> thus avoiding creation of duplicated VmInterview.
>
> Thanks,
> --Vladimir
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net