Skip to main content

Potential logical equality implementation issue

1 reply [Last post]
ychen2
Offline
Joined: 2007-05-08

Hi,

The logical equality implementation in org.mobicents.slee.runtime classes seem to contain some common pitfalls.

SbbEntity -- Only equals() is implemented but not hashcode()
SleeActivityHandle -- Use of instanceof operator in equals()

In other words, the equals() implementation in these two classes does not strictly comply with the Object.equals() contract. If this is *not* the intention of the programmers of these two classes, they should be fixed.

Just thought someone among the mobicents contributors may care about this.

ychen

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
eduardomartins
Offline
Joined: 2005-10-10

Hi ychen, thanks for pointing out these. I've opened a issue for it. See https://mobicents.dev.java.net/issues/show_bug.cgi?id=226

Btw, if you find something you are sure it is a bug then you can open a new issue :-)