Skip to main content

Please review my fix for 6559403

5 replies [Last post]
Anonymous

Please review my fix for 6559403

Diff is here -
https://jtharness.dev.java.net/source/browse/jtharness?rev=330&view=rev

Note: removing unused FeatureManager.TEMPLATE_PROPAGATE and
FeatureManager.PROPAGATE was approved by the customer.

Thanks in advance,

Mikhail Ershov

---------------------------------------------------------------------
To unsubscribe, e-mail: interest-unsubscribe@jtharness.dev.java.net
For additional commands, e-mail: interest-help@jtharness.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Ok, that's fine then.

I am still weary of allowing test suites to make this disappear, especially when disabling them isn't overly detrimental. It makes documentation quite difficult to write.

ersh
Offline
Joined: 2006-10-18
Points: 0

Integrated

bkurotsu
Offline
Joined: 2004-12-13
Points: 0

Question - so what currently controls whether propagation is enabled? It doesn't seem quite right for a "feature" toggle to directly control a menu item. So the description of the feature seems wrong - does this toggle control whether propagation is active or not? If no, then what does control this. And if no, why is there are separate control to activate the menu item - should the menu item activate itself when a configuration has propagation turned on?

ersh
Offline
Joined: 2006-10-18
Points: 0

The menu item is always visible currently.
Condition for enabling is
checkUpdatesAction.setEnabled(testSuiteSet
&& interviewParams != null
&& !interviewParams.isTemplate()
&& interviewParams.getTemplatePath() != null);

The customer requested providing way to hide this menu and the solution does it. I saw two possible places to control the menu:

1)ContextManager's JavaTestMenuManager could be the best place if we provide some generic access to menu system. Something like setMenuVisible(menuID, itemID, isVisible). And from my point of view this is wrong place for specified toggling.
2)ContextManager's FeatureManager looks more generic when we need also. But actually many of FeatureManager's flags does not control any business logic. They control menu visibility/enabling and this is what we need. Look at the usages of TEMPLATE_CREATION flag for example. This is why I chose FeatureManager.

As for the description. The description “is Show "check for template update" menu” and this is exactly what this “feature” controls.

Brian Kurotsuchi

Test, ignore.

jtharness@mobileandembedded.org wrote:
> The menu item is always visible currently.
> Condition for enabling is
> checkUpdatesAction.setEnabled(testSuiteSet
> && interviewParams != null
> && !interviewParams.isTemplate()
> && interviewParams.getTemplatePath() != null);
>
> The customer requested providing way to hide this menu and the solution does it. I saw two possible places to control the menu:
>
> 1)ContextManager's JavaTestMenuManager could be the best place if we provide some generic access to menu system. Something like setMenuVisible(menuID, itemID, isVisible). And from my point of view this is wrong place for specified toggling.
> 2)ContextManager's FeatureManager looks more generic when we need also. But actually many of FeatureManager's flags does not control any business logic. They control menu visibility/enabling and this is what we need. Look at the usages of TEMPLATE_CREATION flag for example. This is why I chose FeatureManager.
>
> As for the description. The description “is Show "check for template update" menu” and this is exactly what this “feature” controls.
> [Message sent by forum member 'ersh' (ersh)]
>
> http://forums.java.net/jive/thread.jspa?messageID=230003
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: interest-unsubscribe@jtharness.dev.java.net
> For additional commands, e-mail: interest-help@jtharness.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: interest-unsubscribe@jtharness.dev.java.net
For additional commands, e-mail: interest-help@jtharness.dev.java.net