Skip to main content

Please review my fix for 6460819

6 replies [Last post]
Anonymous

Please review my fix for 6460819

Diff is here -
https://jtharness.dev.java.net/source/browse/jtharness?rev=326&view=rev

Thanks in advance,

Mikhail Ershov

---------------------------------------------------------------------
To unsubscribe, e-mail: interest-unsubscribe@jtharness.dev.java.net
For additional commands, e-mail: interest-help@jtharness.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bkurotsu
Offline
Joined: 2004-12-13

You are planning to fix the issues and add them to this branch before integration?

ersh
Offline
Joined: 2006-10-18

No. These are tiny usability issues I guess. But I'm investigating and filing bugs to IT

Brian Kurotsuchi

If you can provide easy fixes, that would be great. Otherwise, I don't think
they are blockers for integration.

jtharness@mobileandembedded.org wrote:
> No. These are tiny usability issues I guess. But I'm investigating and filing bugs to IT
> [Message sent by forum member 'ersh' (ersh)]
>
> http://forums.java.net/jive/thread.jspa?messageID=230013
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: interest-unsubscribe@jtharness.dev.java.net
> For additional commands, e-mail: interest-help@jtharness.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: interest-unsubscribe@jtharness.dev.java.net
For additional commands, e-mail: interest-help@jtharness.dev.java.net

ersh
Offline
Joined: 2006-10-18

Integrated

bkurotsu
Offline
Joined: 2004-12-13

Fix looks reasonable. Some questions about testing it though:

- Does it work correctly if this sequence is done by the user:
1) start test manager, bring up dialog (Progress Monitor)
2) In Preferences, change the Window style (to MDI for example)
3) Close the test manager

Seems like the code will handle this, as long as it doesn't lose track of which window is being observed.

ersh
Offline
Joined: 2006-10-18

Yes, this scenario works. But I found another UI problems -
1) after switching from tabbed view to MDI with opened ToolDialogs these dialogs disappear from visible area, window/tile or window/cascade bring them back
2) there are some problems with MDI LogViewer
Will investigate and file the issues