Skip to main content

Please review "LogViewer: pressing Enter in empty Find field duplicates lo"

1 reply [Last post]
ersh
Offline
Joined: 2006-10-18
Points: 0

Description
Open Log Viewer.
Collect some logs (e.g. run a test).
To easy evaluate not collect more than couple of records.
Set cursor to find field and press Enter.
Log records will be duplicated with each pressing of Enter.

Suggested Fix
com/sun/javatest/logging/FilteredLogModel.java

@@ -313,7 +313,11 @@
}

public void setSubstring(String substring) {
- this.substring = substring.trim().toUpperCase();
+ substring = substring.trim().toUpperCase();
+ if (this.substring.equals(substring)) {
+ return;
+ }
+ this.substring = substring;
onFilterChanged();
}

The diffs is at http://fisheye4.cenqua.com/browse/jtharness/branches/users/ersh/cr_65651...

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
bbk
Offline
Joined: 2006-10-13
Points: 0

Got no issues to the fix. (not reproducible if the fix is applied).