Skip to main content

Please review fix for: DTF: AIOOBE on receiving if message args is empty

1 reply [Last post]
Anonymous

Alexander,

Could you please review the following simple bugfix for
6482956: DTF: AIOOBE on receiving if message args is empty

The problem is about inability of DTF (distr test framework) to handle
Messages with empty array of strings.

On Java SE side, we indeed require at least one string to be present
(we calculate which handle_* method to invoke based on that info), but
on Java ME side there is no such requirement.

So, on Java ME side we should not throw confusing
ArrayIndexOutOfBoundException at all, and on Java SE side we should
provide helpful message why Messages with empty args are not accepted.

Take a look:
http://fisheye4.cenqua.com/changelog/cqme/?cs=1337

Thanks,
--Vladimir

P.S. I tried to make the fix as simple as possible since we almost at
the Code Freeze stage. So, there is a small code duplication (2-3
simple lines), but I didn't want to change any more dramatic
changes. And once we convert Java SE side of distr tests to use Messenger in a
matter similar to Java ME side, there wil be no duplication. Clearly,
such change cannot be done right now.

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Alexander Alexeev

Hi Vladimir,

looks good.

Thanks,
Alexander

Vladimir Sizikov wrote:
> Alexander,
>
> Could you please review the following simple bugfix for
> 6482956: DTF: AIOOBE on receiving if message args is empty
>
> The problem is about inability of DTF (distr test framework) to handle
> Messages with empty array of strings.
>
> On Java SE side, we indeed require at least one string to be present
> (we calculate which handle_* method to invoke based on that info), but
> on Java ME side there is no such requirement.
>
> So, on Java ME side we should not throw confusing
> ArrayIndexOutOfBoundException at all, and on Java SE side we should
> provide helpful message why Messages with empty args are not accepted.
>
> Take a look:
> http://fisheye4.cenqua.com/changelog/cqme/?cs=1337
>
> Thanks,
> --Vladimir
>
> P.S. I tried to make the fix as simple as possible since we almost at
> the Code Freeze stage. So, there is a small code duplication (2-3
> simple lines), but I didn't want to change any more dramatic
> changes. And once we convert Java SE side of distr tests to use Messenger in a
> matter similar to Java ME side, there wil be no duplication. Clearly,
> such change cannot be done right now.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net