Skip to main content

Please review: fix for ISSUE #173 and new feature of Test Export.

5 replies [Last post]
Anonymous

Guys,

I've fixed the issue #173:
https://cqme.dev.java.net/issues/show_bug.cgi?id=173

This update not only fixes the bug, but also adds new feature to Test
Export: exporting agent.dat file. Now, an editable version of agent.dat
file (agentArgs.txt) is created in the exported bundle directory.
Exported build converts it into binary form and updates agent.dat in the
exported JAR file.

Please review:

http://fisheye4.cenqua.com/changelog/cqme/?cs=1269

Thanks,
Dmitri.

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Dmitri,

The UTFEncoderTool.java contains wrong header and @author tag. I think
this should be changed in accordance with our rules.

Also, I'd advocate not to create a yet another JAR file that contains
just 2 classes and which is highly unlikely to be used by users
directly.

And any new JAR file adds some extra burden on us, we need to document
it, and the more JAR files we have the harder it will be for users to
know which JARs to use for what.

Maybe we just should put these two classes right into ME FW main JAR?
What do you think?

Also, as a side note, at this stage, when we're close to the code
freeze, any big changes should be minimized. ;)

Thanks,
--Vladimir

On Tue, Jun 19, 2007 at 07:00:15PM +0400, Dmitri Trounine wrote:
> Guys,
>
> I've fixed the issue #173:
> https://cqme.dev.java.net/issues/show_bug.cgi?id=173
>
> This update not only fixes the bug, but also adds new feature to Test
> Export: exporting agent.dat file. Now, an editable version of agent.dat
> file (agentArgs.txt) is created in the exported bundle directory.
> Exported build converts it into binary form and updates agent.dat in the
> exported JAR file.
>
> Please review:
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=1269
>
> Thanks,
> Dmitri.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Dmitri Trounine

Vladimir,

I've moved UTFEncoderTool from separate JAR to j2mefw_jt.jar, and fixed
the headers.
The whole update includng these changes is located here:

http://fisheye4.cenqua.com/changelog/cqme/?cs=1306

Thanks,
Dmitri.

Vladimir Sizikov wrote:
> Dmitri,
>
> The UTFEncoderTool.java contains wrong header and @author tag. I think
> this should be changed in accordance with our rules.
>
> Also, I'd advocate not to create a yet another JAR file that contains
> just 2 classes and which is highly unlikely to be used by users
> directly.
>
> And any new JAR file adds some extra burden on us, we need to document
> it, and the more JAR files we have the harder it will be for users to
> know which JARs to use for what.
>
> Maybe we just should put these two classes right into ME FW main JAR?
> What do you think?
>
> Also, as a side note, at this stage, when we're close to the code
> freeze, any big changes should be minimized. ;)
>
> Thanks,
> --Vladimir
>
> On Tue, Jun 19, 2007 at 07:00:15PM +0400, Dmitri Trounine wrote:
>
>> Guys,
>>
>> I've fixed the issue #173:
>> https://cqme.dev.java.net/issues/show_bug.cgi?id=173
>>
>> This update not only fixes the bug, but also adds new feature to Test
>> Export: exporting agent.dat file. Now, an editable version of agent.dat
>> file (agentArgs.txt) is created in the exported bundle directory.
>> Exported build converts it into binary form and updates agent.dat in the
>> exported JAR file.
>>
>> Please review:
>>
>> http://fisheye4.cenqua.com/changelog/cqme/?cs=1269
>>
>> Thanks,
>> Dmitri.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Dmitri,

On Thu, Jun 21, 2007 at 09:23:07PM +0400, Dmitri Trounine wrote:
> I've moved UTFEncoderTool from separate JAR to j2mefw_jt.jar, and fixed
> the headers.
> The whole update includng these changes is located here:
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=1306

The change look good. The only comment I have is to provide
class-level comment for UTFEncoderTool, what's this class
for. Currently, the class-level comment is empty.

Thanks,
--Vladimir

> Vladimir Sizikov wrote:
> >Dmitri,
> >
> >The UTFEncoderTool.java contains wrong header and @author tag. I think
> >this should be changed in accordance with our rules.
> >
> >Also, I'd advocate not to create a yet another JAR file that contains
> >just 2 classes and which is highly unlikely to be used by users
> >directly.
> >
> >And any new JAR file adds some extra burden on us, we need to document
> >it, and the more JAR files we have the harder it will be for users to
> >know which JARs to use for what.
> >
> >Maybe we just should put these two classes right into ME FW main JAR?
> >What do you think?
> >
> >Also, as a side note, at this stage, when we're close to the code
> >freeze, any big changes should be minimized. ;)
> >
> >Thanks,
> > --Vladimir
> >
> >On Tue, Jun 19, 2007 at 07:00:15PM +0400, Dmitri Trounine wrote:
> >
> >>Guys,
> >>
> >>I've fixed the issue #173:
> >>https://cqme.dev.java.net/issues/show_bug.cgi?id=173
> >>
> >>This update not only fixes the bug, but also adds new feature to Test
> >>Export: exporting agent.dat file. Now, an editable version of agent.dat
> >>file (agentArgs.txt) is created in the exported bundle directory.
> >>Exported build converts it into binary form and updates agent.dat in the
> >>exported JAR file.
> >>
> >>Please review:
> >>
> >>http://fisheye4.cenqua.com/changelog/cqme/?cs=1269
> >>
> >>Thanks,
> >> Dmitri.
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> >>For additional commands, e-mail: meframework-help@cqme.dev.java.net
> >>
> >>
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> >For additional commands, e-mail: meframework-help@cqme.dev.java.net
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Dmitri Trounine

Vladimir,

thank you for review! I've added the comments, please take a look:

http://fisheye4.cenqua.com/changelog/cqme/?cs=1315

Thanks,
Dmitri.

Vladimir Sizikov wrote:
> Dmitri,
>
> On Thu, Jun 21, 2007 at 09:23:07PM +0400, Dmitri Trounine wrote:
>
>> I've moved UTFEncoderTool from separate JAR to j2mefw_jt.jar, and fixed
>> the headers.
>> The whole update includng these changes is located here:
>>
>> http://fisheye4.cenqua.com/changelog/cqme/?cs=1306
>>
>
> The change look good. The only comment I have is to provide
> class-level comment for UTFEncoderTool, what's this class
> for. Currently, the class-level comment is empty.
>
> Thanks,
> --Vladimir
>
>
>> Vladimir Sizikov wrote:
>>
>>> Dmitri,
>>>
>>> The UTFEncoderTool.java contains wrong header and @author tag. I think
>>> this should be changed in accordance with our rules.
>>>
>>> Also, I'd advocate not to create a yet another JAR file that contains
>>> just 2 classes and which is highly unlikely to be used by users
>>> directly.
>>>
>>> And any new JAR file adds some extra burden on us, we need to document
>>> it, and the more JAR files we have the harder it will be for users to
>>> know which JARs to use for what.
>>>
>>> Maybe we just should put these two classes right into ME FW main JAR?
>>> What do you think?
>>>
>>> Also, as a side note, at this stage, when we're close to the code
>>> freeze, any big changes should be minimized. ;)
>>>
>>> Thanks,
>>> --Vladimir
>>>
>>> On Tue, Jun 19, 2007 at 07:00:15PM +0400, Dmitri Trounine wrote:
>>>
>>>
>>>> Guys,
>>>>
>>>> I've fixed the issue #173:
>>>> https://cqme.dev.java.net/issues/show_bug.cgi?id=173
>>>>
>>>> This update not only fixes the bug, but also adds new feature to Test
>>>> Export: exporting agent.dat file. Now, an editable version of agent.dat
>>>> file (agentArgs.txt) is created in the exported bundle directory.
>>>> Exported build converts it into binary form and updates agent.dat in the
>>>> exported JAR file.
>>>>
>>>> Please review:
>>>>
>>>> http://fisheye4.cenqua.com/changelog/cqme/?cs=1269
>>>>
>>>> Thanks,
>>>> Dmitri.
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>>>> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>>>>
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>>> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Dmitri,

Very good. Please, commit.

--VVS

On Fri, Jun 22, 2007 at 11:04:44AM +0400, Dmitri Trounine wrote:
> Vladimir,
>
> thank you for review! I've added the comments, please take a look:
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=1315
>
> Thanks,
> Dmitri.
>
> Vladimir Sizikov wrote:
> >Dmitri,
> >
> >On Thu, Jun 21, 2007 at 09:23:07PM +0400, Dmitri Trounine wrote:
> >
> >>I've moved UTFEncoderTool from separate JAR to j2mefw_jt.jar, and fixed
> >>the headers.
> >>The whole update includng these changes is located here:
> >>
> >>http://fisheye4.cenqua.com/changelog/cqme/?cs=1306
> >>
> >
> >The change look good. The only comment I have is to provide
> >class-level comment for UTFEncoderTool, what's this class
> >for. Currently, the class-level comment is empty.
> >
> >Thanks,
> > --Vladimir
> >
> >
> >>Vladimir Sizikov wrote:
> >>
> >>>Dmitri,
> >>>
> >>>The UTFEncoderTool.java contains wrong header and @author tag. I think
> >>>this should be changed in accordance with our rules.
> >>>
> >>>Also, I'd advocate not to create a yet another JAR file that contains
> >>>just 2 classes and which is highly unlikely to be used by users
> >>>directly.
> >>>
> >>>And any new JAR file adds some extra burden on us, we need to document
> >>>it, and the more JAR files we have the harder it will be for users to
> >>>know which JARs to use for what.
> >>>
> >>>Maybe we just should put these two classes right into ME FW main JAR?
> >>>What do you think?
> >>>
> >>>Also, as a side note, at this stage, when we're close to the code
> >>>freeze, any big changes should be minimized. ;)
> >>>
> >>>Thanks,
> >>> --Vladimir
> >>>
> >>>On Tue, Jun 19, 2007 at 07:00:15PM +0400, Dmitri Trounine wrote:
> >>>
> >>>
> >>>>Guys,
> >>>>
> >>>>I've fixed the issue #173:
> >>>>https://cqme.dev.java.net/issues/show_bug.cgi?id=173
> >>>>
> >>>>This update not only fixes the bug, but also adds new feature to Test
> >>>>Export: exporting agent.dat file. Now, an editable version of agent.dat
> >>>>file (agentArgs.txt) is created in the exported bundle directory.
> >>>>Exported build converts it into binary form and updates agent.dat in
> >>>>the exported JAR file.
> >>>>
> >>>>Please review:
> >>>>
> >>>>http://fisheye4.cenqua.com/changelog/cqme/?cs=1269
> >>>>
> >>>>Thanks,
> >>>> Dmitri.
> >>>>
> >>>>---------------------------------------------------------------------
> >>>>To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> >>>>For additional commands, e-mail: meframework-help@cqme.dev.java.net
> >>>>
> >>>>
> >>>>
> >>>---------------------------------------------------------------------
> >>>To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> >>>For additional commands, e-mail: meframework-help@cqme.dev.java.net
> >>>
> >>>
> >>>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> >>For additional commands, e-mail: meframework-help@cqme.dev.java.net
> >>
> >>
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> >For additional commands, e-mail: meframework-help@cqme.dev.java.net
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net