Skip to main content

Please review bugfix for #170: CldcTckCommand swallows stack traces of various exceptions

2 replies [Last post]
Anonymous

Alexander,

Could you please review the following (very straightforward) bugfix
for ISSUE #170: CldcTckCommand swallows stack traces of various
exceptions.

http://fisheye4.cenqua.com/changelog/cqme/?cs=1122

Thanks,
--Vladimir

P.S. Just to make sure you've seen my other request for review, here's
a little reminder: I'm waiting for "Improvements in BasicTckInterview
(ISSUE #163)" review. :)

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Alexander Alexeev

Hi Vladimir,

looks good. I just curious is it intentional to create branch from 1.1.1 release
branch? It may complicates merging branch with the trunk.

The ISSUE #163 is one of my primary tasks ;-) A lot of changes! I need time to
review all of them. Will try to send comments today.

Thanks,
Alexander

Vladimir Sizikov wrote:
> Alexander,
>
> Could you please review the following (very straightforward) bugfix
> for ISSUE #170: CldcTckCommand swallows stack traces of various
> exceptions.
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=1122
>
> Thanks,
> --Vladimir
>
> P.S. Just to make sure you've seen my other request for review, here's
> a little reminder: I'm waiting for "Improvements in BasicTckInterview
> (ISSUE #163)" review. :)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Hi Alexander,

On Fri, Jun 01, 2007 at 01:19:10PM +0400, Alexander Alexeev wrote:
> looks good. I just curious is it intentional to create branch from
> 1.1.1 release branch? It may complicates merging branch with the
> trunk.

I was working on FW 1.1.1 branch, investigating one of the test
failures, and hence the fix was there first too.

The merging was not problematic (just one of the files didn't need the
fix, so I excluded that file from commit).

> The ISSUE #163 is one of my primary tasks ;-) A lot of changes! I
> need time to review all of them. Will try to send comments today.

Very good, thanks! Will wait for your comments.

--Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net