Skip to main content

Please review bugfix for #159: NPE for double-duty tests with no sources

2 replies [Last post]
Anonymous

Alexander, team,

Could you please review the fix for
Fixed ISSUE #159: NPE for double-duty tests with no sources

http://fisheye4.cenqua.com/changelog/cqme/?cs=1035

I just added a check against null. Thus, we avoid NPE, and the proper
error message is displayed, if needed.

Thanks,
--Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Alexander Alexeev

Hi Vladimir,

is my understanding right and now error message about absence of files will be
processed in another place as for usual tests (not double-duty)? If yes I'm OK
with changes.

Thanks,
Alexander

Vladimir Sizikov wrote:
> Alexander, team,
>
> Could you please review the fix for
> Fixed ISSUE #159: NPE for double-duty tests with no sources
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=1035
>
> I just added a check against null. Thus, we avoid NPE, and the proper
> error message is displayed, if needed.
>
> Thanks,
> --Vladimir
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Alexander,

On Mon, May 28, 2007 at 02:10:44PM +0400, Alexander Alexeev wrote:
> is my understanding right and now error message about absence of
> files will be processed in another place as for usual tests (not
> double-duty)? If yes I'm OK with changes.

Right. The problem with double-duty case was the very confusing
NullPointerException without any indication on what's wrong and where.

For non double-duty tests, we get the Error: cannot find class.
This is much better and suggests where the problem is.

After the fix, we'll get the same error message in both cases.

Thanks,
--Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net