Skip to main content

Please review: fixes for ISSUE #45 and ISSUE #153

1 reply [Last post]
Anonymous

Hi All,

New update is ready for review! It has three successive parts:

1. Fix for ISSUE #45 as I already sent a couple of weeks ago:
http://fisheye4.cenqua.com/changelog/cqme/?cs=989
It was already reviewed by Misha, nothing new in this changset.

2. After discussion with Misha we realized that 'Run exported test' mode
is confusing and should be removed from interview. So I created ISSUE
#153 for this task and here is the fix:
http://fisheye4.cenqua.com/changelog/cqme/?cs=991

3. Finally, I fixed typos and made rewording as Misha suggested:
http://fisheye4.cenqua.com/changelog/cqme/?cs=992

Thanks,
Dmitri.

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Hi Dmitri,

The changes overall looks good.

There are two minor comments:

1. It would be good to rename "exportedMode" to something less
confusing (in code and build settings)

Just take a look in method:

boolean isTestExportMode() {
return something & !exportedMode
}

It took me some time to figure out why the negation in the return
statement. It's very easy to conffuse exportED mode with export mode.

I'd suggest something like runExportedTest.

2. Typo in exportMode.html:

"When a test is successfully exported, it __do__ not..."

Should be "it does not", right?

Once you've fixed these minor issues, feel free to commit.

Thanks,
--Vladimir

On Thu, May 24, 2007 at 01:04:03AM -0700, Dmitri Trounine wrote:
> Hi All,
>
> New update is ready for review! It has three successive parts:
>
> 1. Fix for ISSUE #45 as I already sent a couple of weeks ago:
> http://fisheye4.cenqua.com/changelog/cqme/?cs=989
> It was already reviewed by Misha, nothing new in this changset.
>
> 2. After discussion with Misha we realized that 'Run exported test' mode
> is confusing and should be removed from interview. So I created ISSUE
> #153 for this task and here is the fix:
> http://fisheye4.cenqua.com/changelog/cqme/?cs=991
>
> 3. Finally, I fixed typos and made rewording as Misha suggested:
> http://fisheye4.cenqua.com/changelog/cqme/?cs=992
>
> Thanks,
> Dmitri.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net