Skip to main content

Please review fix for ISSUE #150

5 replies [Last post]
Anonymous

Hi Vladimir,

please review fix for ISSUE #150: RMSReader should clear display the absence of
record store. The changeset: http://fisheye4.cenqua.com/changelog/cqme/?cs=952

Thanks,
Alexander

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Hi Alexander,

On Mon, May 21, 2007 at 01:55:21PM +0400, Alexander Alexeev wrote:
> Hi Vladimir,
>
> please review fix for ISSUE #150: RMSReader should clear display the
> absence of
> record store. The changeset:
> http://fisheye4.cenqua.com/changelog/cqme/?cs=952

The RecordStore, once being opened, is never closed. My understanding
is that, as with any limited resource, every open() must be accompanied
by close(), isn't it?

Also, any exceptions while reading the store, are presented to users
via alert(), but the application does not exit after that, is that
correct?

I'd say that if we cannot read the RecordStore for some reason, we
should notify the user, close the store and bail out, finishing the
application. Am I missing something?

Just to reiterate, the store must be closed no matter whith execution
branche we took, whether everything was fine, or whether some
unexpected exceptions were thrown.

Thanks,
--Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Alexander Alexeev

Hi Vladimir,

agreed with all but one, please see below.

Vladimir Sizikov wrote:
> Hi Alexander,
>
> On Mon, May 21, 2007 at 01:55:21PM +0400, Alexander Alexeev wrote:
>> Hi Vladimir,
>>
>> please review fix for ISSUE #150: RMSReader should clear display the
>> absence of
>> record store. The changeset:
>> http://fisheye4.cenqua.com/changelog/cqme/?cs=952
>
> The RecordStore, once being opened, is never closed. My understanding
> is that, as with any limited resource, every open() must be accompanied
> by close(), isn't it?
>
> Also, any exceptions while reading the store, are presented to users
> via alert(), but the application does not exit after that, is that
> correct?
>
> I'd say that if we cannot read the RecordStore for some reason, we
> should notify the user, close the store and bail out, finishing the
> application. Am I missing something?
>
I'm thinking real device in development can have raw implementation of record
store and not exiting after exception can allow to user to view part of
information that can be helpful. What do you think?

Thanks,
Alexander

> Just to reiterate, the store must be closed no matter whith execution
> branche we took, whether everything was fine, or whether some
> unexpected exceptions were thrown.
>
> Thanks,
> --Vladimir
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Hi Alexander,

On Mon, May 21, 2007 at 02:52:46PM +0400, Alexander Alexeev wrote:
> agreed with all but one, please see below.
>
> I'm thinking real device in development can have raw implementation of
> record
> store and not exiting after exception can allow to user to view part of
> information that can be helpful. What do you think?

I'm OK with it as long as you are sure that the infrastructure can
handle incomplete data (and no misteryous NPEs, OutOfBoundsExceptions
can be thrown). If not, we're not helping users but rather
confuse them more. :)

Thanks,
--Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Alexander Alexeev

Hi Vladimir,

please see changes on http://fisheye4.cenqua.com/changelog/cqme/?cs=955

Now the MIDlet will finish work in case of Throwable since it really indicates
something is wrong with data. On the other hand RecordStore exception have
little chance to affect GUI engine so MIDlet will continue to work.

Thanks,
Alexander

Vladimir Sizikov wrote:
> Hi Alexander,
>
> On Mon, May 21, 2007 at 02:52:46PM +0400, Alexander Alexeev wrote:
>> agreed with all but one, please see below.
>>
>> I'm thinking real device in development can have raw implementation of
>> record
>> store and not exiting after exception can allow to user to view part of
>> information that can be helpful. What do you think?
>
> I'm OK with it as long as you are sure that the infrastructure can
> handle incomplete data (and no misteryous NPEs, OutOfBoundsExceptions
> can be thrown). If not, we're not helping users but rather
> confuse them more. :)
>
> Thanks,
> --Vladimir
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Alexander,

The changes look good.

Thanks,
--Vladimir

On Mon, May 21, 2007 at 04:16:00PM +0400, Alexander Alexeev wrote:
> Hi Vladimir,
>
> please see changes on http://fisheye4.cenqua.com/changelog/cqme/?cs=955
>
> Now the MIDlet will finish work in case of Throwable since it really
> indicates
> something is wrong with data. On the other hand RecordStore exception have
> little chance to affect GUI engine so MIDlet will continue to work.
>
> Thanks,
> Alexander

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net