Skip to main content

Please review: fix for issue #130 (Usability issue with exported tests rebuilding)

2 replies [Last post]
Anonymous

Folks,

Please review the fix for issue #130 (About location of exported JAR and
JAD files).
In this update the locations of originally exported files and rebuilt
files were changed.

http://fisheye4.cenqua.com/changelog/cqme/?cs=865

Thanks,
Dmitri.

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Dmitri,

On Wed, May 09, 2007 at 04:28:11PM -0700, Dmitri Trounine wrote:
> Please review the fix for issue #130 (About location of exported JAR and
> JAD files).
> In this update the locations of originally exported files and rebuilt
> files were changed.
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=865

The change looks good. Please proceed with the commit.

I also noticed that you tried to solve "jam files present in MIDP
mode" problem. And indeed the JAM files are no longer in testNNN
directories, but they are still presest in the top-level directory:

test1.jam
test2.jam
test3.jam, etc.

So the ISSUE #120 (Test export always produces JAM files) is not yet
fully solved.

Thanks,
--Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Dmitri Trounine

Vladimir,

Thanks for review.

And first moment while fixing the issue #130, I've also thought that I
was fixing issue #120 too! :) But ExportBundler only moves JAD and JAR
files to right locations, it doesn't produce them. The root cause of
#120 is in ExportBuilder.

Thanks
Dmitri.

Vladimir Sizikov wrote:
> Dmitri,
>
> On Wed, May 09, 2007 at 04:28:11PM -0700, Dmitri Trounine wrote:
>
>> Please review the fix for issue #130 (About location of exported JAR and
>> JAD files).
>> In this update the locations of originally exported files and rebuilt
>> files were changed.
>>
>> http://fisheye4.cenqua.com/changelog/cqme/?cs=865
>>
>
> The change looks good. Please proceed with the commit.
>
> I also noticed that you tried to solve "jam files present in MIDP
> mode" problem. And indeed the JAM files are no longer in testNNN
> directories, but they are still presest in the top-level directory:
>
> test1.jam
> test2.jam
> test3.jam, etc.
>
> So the ISSUE #120 (Test export always produces JAM files) is not yet
> fully solved.
>
> Thanks,
> --Vladimir
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net