Skip to main content

please review change for issue #92 and #99 (IPv6 related)

3 replies [Last post]
Anonymous

Hi Vladimir,

Can you review the change since you have been more or less involved in
the discussion?

http://fisheye4.cenqua.com/changelog/cqme/?cs=849

Thanks,
Allen

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Vladimir Sizikov

Hi Allen,

The changes are good, with one place that managed to avoid the proper
conversion:

CommInterview.getLocalhost() still returns the 'raw' IPv6 address, and
this value is being used extensively in all CLDC/MIDP runs.

I guess, we should convert the return value from getLocalHost(), and
update the javadocs, to make it clear on the returned format.

Once it's done, please proceed with the commit.

Thanks,
--Vladimir

On Fri, May 04, 2007 at 04:53:22PM -0700, Allen Wang wrote:
> Hi Vladimir,
>
> Can you review the change since you have been more or less involved in
> the discussion?
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=849
>
> Thanks,
> Allen
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Allen Wang

Hi Vladimir,

I have committed the changes.

However, another issue comes to my mind. After Alexander's update,
DTFInterview no longer has a reference to CommInterview and cannot use
CommInterview.getLocalhost() to get the host name. Of course, we can use
DTFInterview.setHostName(). But this API must be invoked after
CommInterview. Given the interview structure, I cannot think of any way
to proper invoke this API from TCK's interview:

iComm = new CommInterview(this, CommInterview.CDC_MODE, true);
iComm.setTransport(TransportConstants.UDP_TRANSPORT);
iDTF = new DTFInterview(this, false, true);
// ...
callInterview(iComm, callInterview(iDTF, ...))

Note that it is useful to get the host name so that we can correctly set
the default answer for JavaTest host IP question.

So I suggest to add an optional reference to CommInterview from
DTFInterview. If not null, we invoke CommInterview.getLocalhost()
properly. The reference can be passed into DTFInterview's as a parameter
of the constructor.

Thanks,
Allen

Vladimir Sizikov wrote:
> Hi Allen,
>
> The changes are good, with one place that managed to avoid the proper
> conversion:
>
> CommInterview.getLocalhost() still returns the 'raw' IPv6 address, and
> this value is being used extensively in all CLDC/MIDP runs.
>
> I guess, we should convert the return value from getLocalHost(), and
> update the javadocs, to make it clear on the returned format.
>
> Once it's done, please proceed with the commit.
>
> Thanks,
> --Vladimir
>
> On Fri, May 04, 2007 at 04:53:22PM -0700, Allen Wang wrote:
>
>> Hi Vladimir,
>>
>> Can you review the change since you have been more or less involved in
>> the discussion?
>>
>> http://fisheye4.cenqua.com/changelog/cqme/?cs=849
>>
>> Thanks,
>> Allen
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Alexander Alexeev

Hi Allen,

I propose that we postpone a solution to that issue. The upcoming commit from
Maxim Sokolnikov about pluggable communication channel will significantly affect
CommInterview. So then we possibly will need to update DTFInterview.

Thanks,
Alexander

Allen Wang wrote:
> Hi Vladimir,
>
> I have committed the changes.
>
> However, another issue comes to my mind. After Alexander's update,
> DTFInterview no longer has a reference to CommInterview and cannot use
> CommInterview.getLocalhost() to get the host name. Of course, we can use
> DTFInterview.setHostName(). But this API must be invoked after
> CommInterview. Given the interview structure, I cannot think of any way
> to proper invoke this API from TCK's interview:
>
> iComm = new CommInterview(this, CommInterview.CDC_MODE, true);
> iComm.setTransport(TransportConstants.UDP_TRANSPORT);
> iDTF = new DTFInterview(this, false, true);
> // ...
> callInterview(iComm, callInterview(iDTF, ...))
>
> Note that it is useful to get the host name so that we can correctly set
> the default answer for JavaTest host IP question.
>
> So I suggest to add an optional reference to CommInterview from
> DTFInterview. If not null, we invoke CommInterview.getLocalhost()
> properly. The reference can be passed into DTFInterview's as a parameter
> of the constructor.
>
> Thanks,
> Allen
>
> Vladimir Sizikov wrote:
>> Hi Allen,
>>
>> The changes are good, with one place that managed to avoid the proper
>> conversion:
>>
>> CommInterview.getLocalhost() still returns the 'raw' IPv6 address, and
>> this value is being used extensively in all CLDC/MIDP runs.
>>
>> I guess, we should convert the return value from getLocalHost(), and
>> update the javadocs, to make it clear on the returned format.
>>
>> Once it's done, please proceed with the commit.
>>
>> Thanks,
>> --Vladimir
>>
>> On Fri, May 04, 2007 at 04:53:22PM -0700, Allen Wang wrote:
>>
>>> Hi Vladimir,
>>>
>>> Can you review the change since you have been more or less involved
>>> in the discussion?
>>>
>>> http://fisheye4.cenqua.com/changelog/cqme/?cs=849
>>>
>>> Thanks,
>>> Allen
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net