Skip to main content

Re: Please review: fix for issue #109 (support of emty JAR URLs in Test Export).

1 reply [Last post]
Anonymous

Alexander Alexeev wrote:
> Dmitri,
>
> now we have a duplication of code: creation of jad entries in
> DefaultContentHandler and in MidExportBuilder. Once we change
> something in one
> place we need to change in another. The creation jad content from
> manifest is
> clear way to provide right info in jad. Also code duplication was
> removed.
We cannot avoid duplication here, because ContentHandler interface
doesn't support empty JAR URL prefix. It requires such parameters as
host, port etc, and it always builds an URL starting from http://

I agree that obtaining data for JAD file from manifest is better, but it
won't remove code duplication:

http://fisheye4.cenqua.com/changelog/cqme/branches/users/dtrounine/testE...

Thanks,
Dmitry.

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Alexander Alexeev

Dmitri,

the changes look good, now we don't need to fix code if midlet's attributes will
be changed.

Thanks,
Alexander

Dmitri Trounine wrote:
> Alexander Alexeev wrote:
>> Dmitri,
>>
>> now we have a duplication of code: creation of jad entries in
>> DefaultContentHandler and in MidExportBuilder. Once we change
>> something in one
>> place we need to change in another. The creation jad content from
>> manifest is
>> clear way to provide right info in jad. Also code duplication was
>> removed.
> We cannot avoid duplication here, because ContentHandler interface
> doesn't support empty JAR URL prefix. It requires such parameters as
> host, port etc, and it always builds an URL starting from http://
>
> I agree that obtaining data for JAD file from manifest is better, but it
> won't remove code duplication:
>
> http://fisheye4.cenqua.com/changelog/cqme/branches/users/dtrounine/testE...
>
>
> Thanks,
> Dmitry.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net