Skip to main content

Please review: fix for issue #109 (support of emty JAR URLs in Test Export).

3 replies [Last post]
Anonymous

Guys,

please review a new update fixing the issue #109:

http://fisheye4.cenqua.com/changelog/cqme/?cs=796

For more details about the fix see my comments to the issue:

https://cqme.dev.java.net/issues/show_bug.cgi?id=109

Thanks,
Dmitri.

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Alexander Alexeev

Hi Dmitri,

I've noticed you are calling generateDefaultJAD() from createJad(String jarName,
Manifest manifest). I think more appropriate to use information from manifest
for creating jad.

Thanks,
Alexander
Dmitri Trounine wrote:
> Guys,
>
> please review a new update fixing the issue #109:
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=796
>
> For more details about the fix see my comments to the issue:
>
> https://cqme.dev.java.net/issues/show_bug.cgi?id=109
>
> Thanks,
> Dmitri.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Dmitri Trounine

Alexander Alexeev wrote:
> Hi Dmitri,
>
> I've noticed you are calling generateDefaultJAD() from
> createJad(String jarName,
> Manifest manifest). I think more appropriate to use information from
> manifest
> for creating jad.
What is wrong with generateDefaultJAD()?
MidExportBuilder generates the JAD files in the same way as
MidHttpExecutionServer does, except supporting empty JAR URL prefix.
Information from manifest is used when adding JAD-addon to JAD files.

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Alexander Alexeev

Dmitri,

now we have a duplication of code: creation of jad entries in
DefaultContentHandler and in MidExportBuilder. Once we change something in one
place we need to change in another. The creation jad content from manifest is
clear way to provide right info in jad. Also code duplication was removed.

Thanks,
Alexander

Dmitri Trounine wrote:
> Alexander Alexeev wrote:
>> Hi Dmitri,
>>
>> I've noticed you are calling generateDefaultJAD() from
>> createJad(String jarName,
>> Manifest manifest). I think more appropriate to use information from
>> manifest
>> for creating jad.
> What is wrong with generateDefaultJAD()?
> MidExportBuilder generates the JAD files in the same way as
> MidHttpExecutionServer does, except supporting empty JAR URL prefix.
> Information from manifest is used when adding JAD-addon to JAD files.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net