Skip to main content

[PATCH] File module patch to build for Solaris

2 replies [Last post]
Anonymous

Hi,

Solaris has definition of O_CREAT to be 0x100, as well on Windows while
Linux is 0x40.

As those macro definitions used in PCSL file module are fairly
standardized, I am not sure why we don't simply use the standard header.

Attached is a patch to use fcntl.h and stdio.h and define PCSL version
by using the standard macros.

This allows Solaris build to complete and pass the donuts test. If there
is a concern on using standard headers, I would like to learn about
them, and we can revert back to do a similar converting process for
posix file modules as well.

Cheers,
Henry

---------------------------------------------------------------------
To unsubscribe, e-mail: feature-unsubscribe@phoneme.dev.java.net
For additional commands, e-mail: feature-help@phoneme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
aap031
Offline
Joined: 2006-10-18

Hi Henry,

Thank you! We are eager to use your contribution. However to be able to do so we would need you to sign the Contributor Agreement. Sorry for that but that's strictly required. Could you please go to https://mobileandembedded.dev.java.net/content/sca.html and follow the instructions. Contribution process description is here if you like https://mobileandembedded.dev.java.net/content/contribute.html.

Please let me know if you have any questions

Thanks,
Andrey

Henry Jen

Forgot the attachment, here it goes again.

Cheers,
Henry

Henry Jen wrote:
> Hi,
>
> Solaris has definition of O_CREAT to be 0x100, as well on Windows while
> Linux is 0x40.
>
> As those macro definitions used in PCSL file module are fairly
> standardized, I am not sure why we don't simply use the standard header.
>
> Attached is a patch to use fcntl.h and stdio.h and define PCSL version
> by using the standard macros.
>
> This allows Solaris build to complete and pass the donuts test. If there
> is a concern on using standard headers, I would like to learn about
> them, and we can revert back to do a similar converting process for
> posix file modules as well.
>
> Cheers,
> Henry
>

[pcsl_file.diff]
---------------------------------------------------------------------
To unsubscribe, e-mail: feature-unsubscribe@phoneme.dev.java.net
For additional commands, e-mail: feature-help@phoneme.dev.java.net