Skip to main content

Please review: fix for rfe106 (interactive agent for test export mode)

4 replies [Last post]
Anonymous

Guys,

Please review new interactive agent for test export mode:

http://fisheye4.cenqua.com/changelog/cqme/?cs=749

Thanks,
Dmitri.

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Reply viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.
Maxim Dolidze

Dmitri,

I've finally reviewed this change. I've found some issues
- wrong class names in JAR manifests
build/manifestgui should contain MIDletGUIAgent (unchanged)
build/manifest_export_gui hould contain ExportMIDletGUIAgent
- ExportMIDletGUIAgent.saveStatus() should call super.saveStatus() if we
still want to save results in RMS
- not sure about changes in nbproject/project.xml (may be exclude from
commit?)

Dmitri Trounine wrote:
> Guys,
>
> Please review new interactive agent for test export mode:
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=749
>
> Thanks,
> Dmitri.
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Dmitri,

We really close to the end of FW 1.2 dev cycle and have quite a few
outstanding issues to resolve, the ones that we must resolve before FW
1.2 ships.

I propose to postpone this change for FW 1.2.1, and not spend any time
on it right now - it adds some code to common classes as interview,
adds new JAR files (which are effectively a port of public interface
to ME Framework), and I'd like to have all this better reviewed,
tested and documented, and we just don't have enough time for this
right now.

Sorry, I hope you understand and agree with the reasoning.

Any chinge in our official sources should be minimized at this point,
only require fixes should be implemented. Otherwise, we'll never
stabilize the sources for the release.

Thanks,
--Vladimir

On Thu, Apr 26, 2007 at 03:51:31PM +0400, Dmitri Trounine wrote:
> Guys,
>
> Please review new interactive agent for test export mode:
>
> http://fisheye4.cenqua.com/changelog/cqme/?cs=749
>
> Thanks,
> Dmitri.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
> For additional commands, e-mail: meframework-help@cqme.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Dmitri Trounine

Sure, this change is not significant for ME Framework 1.2.

I've just integrated new GUI agent already made by Maxim Dolidze into
framework as we agreed. *No need to review it and merge to trunk* - we
are going to use it as is at J1. However, as I mentioned in rfe #106
(and discussed with Alexander Alexeev), adding such agent to ME
Framework may have sens. Maybe, in 1.2.1

Thanks,
Dmitri.

Vladimir Sizikov wrote:

>Dmitri,
>
>We really close to the end of FW 1.2 dev cycle and have quite a few
>outstanding issues to resolve, the ones that we must resolve before FW
>1.2 ships.
>
>I propose to postpone this change for FW 1.2.1, and not spend any time
>on it right now - it adds some code to common classes as interview,
>adds new JAR files (which are effectively a port of public interface
>to ME Framework), and I'd like to have all this better reviewed,
>tested and documented, and we just don't have enough time for this
>right now.
>
>Sorry, I hope you understand and agree with the reasoning.
>
>Any chinge in our official sources should be minimized at this point,
>only require fixes should be implemented. Otherwise, we'll never
>stabilize the sources for the release.
>
>Thanks,
> --Vladimir
>
>On Thu, Apr 26, 2007 at 03:51:31PM +0400, Dmitri Trounine wrote:
>
>
>>Guys,
>>
>>Please review new interactive agent for test export mode:
>>
>>http://fisheye4.cenqua.com/changelog/cqme/?cs=749
>>
>>Thanks,
>> Dmitri.
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>>For additional commands, e-mail: meframework-help@cqme.dev.java.net
>>
>>
>>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
>For additional commands, e-mail: meframework-help@cqme.dev.java.net
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net

Vladimir Sizikov

Dima,

On Fri, Apr 27, 2007 at 11:33:39AM +0400, Dmitri Trounine wrote:
> I've just integrated new GUI agent already made by Maxim Dolidze into
> framework as we agreed.

Oh, I wrongly assumed that you've quickly wrote it yourself! :)

Maxim, thanks for the contribution!!
I do hope that we'll leverage your contributions (this one and
interactive tests automation) in the future FW
releases.

> *No need to review it and merge to trunk* - we
> are going to use it as is at J1. However, as I mentioned in rfe #106
> (and discussed with Alexander Alexeev), adding such agent to ME
> Framework may have sens. Maybe, in 1.2.1

Agreed! Thanks for the explanation. The code is in the repository for
now and the RFE is open, so we'll not lost this.

Thanks,
--Vladimir

---------------------------------------------------------------------
To unsubscribe, e-mail: meframework-unsubscribe@cqme.dev.java.net
For additional commands, e-mail: meframework-help@cqme.dev.java.net